Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum chunk size to data lake store docs. #4464

Merged
merged 3 commits into from
Nov 14, 2018
Merged

Add maximum chunk size to data lake store docs. #4464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2352b5
Add maximum chunk size to data lake store docs.
jhendrixMSFT Nov 14, 2018
74afa73
fix semantic validation errors
jhendrixMSFT Nov 14, 2018
88bcb6c
deprecate operation FileSystem_Concat
jhendrixMSFT Nov 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 25 additions & 22 deletions ...alake-store/data-plane/Microsoft.DataLakeStore/preview/2015-10-01-preview/filesystem.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"format": "file"
},
"required": true,
"description": "The file contents to include when appending to the file."
"description": "The file contents to include when appending to the file. The maximum content size is 4MB. For content larger than 4MB you must append the content in 4MB chunks."
jhendrixMSFT marked this conversation as resolved.
Show resolved Hide resolved
},
{
"name": "appendMode",
Expand Down Expand Up @@ -277,14 +277,16 @@
}
}
}
},
"/webhdfs/v1/{destinationPath}": {
}
},
"x-ms-paths": {
"/webhdfs/v1/{destinationPath}?op=CONCAT": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a process to deprecate this Concat. We should only have MSConcat. Concat has some problem for which customer faces issues.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can add deprecated: true and update the description string. You want me to do that?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think we should do that. Concat takes in input as queryparameters which causes another IIS filtering 404 error which is notoriously difficult to catch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, see latest commit.

"post": {
"tags": [
"FileSystem"
],
"operationId": "FileSystem_Concat",
"description": "Concatenates the list of source files into the destination file, removing all source files upon success.",
"description": "Concatenates the list of source files into the destination file, removing all source files upon success. This operation has been deprecated, please use operation FileSystem_MsConcat instead.",
"parameters": [
{
"name": "destinationPath",
Expand Down Expand Up @@ -329,10 +331,11 @@
"$ref": "#/definitions/AdlsError"
}
}
}
},
"deprecated": true
}
},
"/webhdfs/v1/{msConcatDestinationPath}": {
"/webhdfs/v1/{msConcatDestinationPath}?op=MSCONCAT": {
"post": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -395,7 +398,7 @@
}
}
},
"/webhdfs/v1/{listFilePath}": {
"/webhdfs/v1/{listFilePath}?op=MSLISTSTATUS": {
jhendrixMSFT marked this conversation as resolved.
Show resolved Hide resolved
"get": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -463,7 +466,7 @@
}
}
},
"/webhdfs/va/{getContentSummaryFilePath}": {
"/webhdfs/va/{getContentSummaryFilePath}?op=GETCONTENTSUMMARY": {
"get": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -509,7 +512,7 @@
}
}
},
"/webhdfs/v1/{getFilePath}": {
"/webhdfs/v1/{getFilePath}?op=MSGETFILESTATUS": {
jhendrixMSFT marked this conversation as resolved.
Show resolved Hide resolved
"get": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -555,7 +558,7 @@
}
}
},
"/webhdfs/v1/{flushFilePath}": {
"/webhdfs/v1/{flushFilePath}?op=APPEND;append=true;flush=true": {
"post": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -621,7 +624,7 @@
}
}
},
"/webhdfs/v1/{directFilePath}": {
"/webhdfs/v1/{directFilePath}?op=APPEND": {
"post": {
"tags": [
"FileSystem"
Expand All @@ -647,7 +650,7 @@
"format": "file"
},
"required": true,
"description": "The file contents to include when appending to the file."
"description": "The file contents to include when appending to the file. The maximum content size is 4MB. For content larger than 4MB you must append the content in 4MB chunks."
},
{
"name": "offset",
Expand Down Expand Up @@ -719,7 +722,7 @@
"format": "file"
},
"required": false,
"description": "The file contents to include when creating the file. This parameter is optional, resulting in an empty file if not specified."
"description": "The file contents to include when creating the file. This parameter is optional, resulting in an empty file if not specified. The maximum content size is 4MB. For content larger than 4MB you must append the content in 4MB chunks."
},
{
"name": "overwrite",
Expand Down Expand Up @@ -834,7 +837,7 @@
}
}
},
"/webhdfs/v1/{setAclFilePath}": {
"/webhdfs/v1/{setAclFilePath}?op=SETACL": {
"put": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -884,7 +887,7 @@
}
}
},
"/webhdfs/v1/{modifyAclFilePath}": {
"/webhdfs/v1/{modifyAclFilePath}?op=MODIFYACLENTRIES": {
"put": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -934,7 +937,7 @@
}
}
},
"/webhdfs/v1/{removeAclFilePath}": {
"/webhdfs/v1/{removeAclFilePath}?op=REMOVEACLENTRIES": {
"put": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -984,7 +987,7 @@
}
}
},
"/webhdfs/v1/{defaultAclFilePath}": {
"/webhdfs/v1/{defaultAclFilePath}?op=REMOVEDEFAULTACL": {
"put": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -1027,7 +1030,7 @@
}
}
},
"/webhdfs/v1/{aclFilePath}": {
"/webhdfs/v1/{aclFilePath}?op=REMOVEACL": {
"put": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -1114,7 +1117,7 @@
}
}
},
"/webhdfs/v1/{filePath}": {
"/webhdfs/v1/{filePath}?op=DELETE": {
"delete": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -1167,7 +1170,7 @@
}
}
},
"/webhdfs/v1/{renameFilePath}": {
"/webhdfs/v1/{renameFilePath}?op=RENAME": {
"put": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -1220,7 +1223,7 @@
}
}
},
"/webhdfs/v1/{setOwnerFilePath}": {
"/webhdfs/v1/{setOwnerFilePath}?op=SETOWNER": {
"put": {
"tags": [
"FileSystem"
Expand Down Expand Up @@ -1277,7 +1280,7 @@
}
}
},
"/webhdfs/v1/{setPermissionFilePath}": {
"/webhdfs/v1/{setPermissionFilePath}?op=SETPERMISSION": {
"put": {
"tags": [
"FileSystem"
Expand Down
6 changes: 3 additions & 3 deletions ...ation/datalake-store/data-plane/Microsoft.DataLakeStore/stable/2016-11-01/filesystem.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
"format": "file"
},
"required": true,
"description": "The file contents to include when appending to the file."
"description": "The file contents to include when appending to the file. The maximum content size is 4MB. For content larger than 4MB you must append the content in 4MB chunks."
},
{
"name": "appendMode",
Expand Down Expand Up @@ -743,7 +743,7 @@
"format": "file"
},
"required": true,
"description": "The file contents to include when appending to the file."
"description": "The file contents to include when appending to the file. The maximum content size is 4MB. For content larger than 4MB you must append the content in 4MB chunks."
},
{
"name": "offset",
Expand Down Expand Up @@ -854,7 +854,7 @@
"format": "file"
},
"required": false,
"description": "The file contents to include when creating the file. This parameter is optional, resulting in an empty file if not specified."
"description": "The file contents to include when creating the file. This parameter is optional, resulting in an empty file if not specified. The maximum content size is 4MB. For content larger than 4MB you must append the content in 4MB chunks."
},
{
"name": "overwrite",
Expand Down