-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modeling assignmentOperations with api-version 2018-11-01 #4590
Conversation
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
As per discussion with Marcin over email, here is what will happen. tracking it here- #4903 |
Signing off from ARM side. |
#4903 is addressed in latest commit |
@annatisch can you take a look again and merge? |
Thanks @haitch - model validation pass is still failing:
|
fixed, @annatisch can you approve? |
Thanks @haitch - I will try to review this afternoon |
@haitch - is this API already deployed/available? |
it was deployed with /operations last week. I've also updated our RP with the rename, the rename deploy soon. |
Thanks - please update this thread when the rename has been deployed (or when deployment has started). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @haitch - the PR looks good! :)
My only comments are minor regarding the consistent capitalization of the descriptions.
...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/assignmentOperation.json
Outdated
Show resolved
Hide resolved
...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/assignmentOperation.json
Show resolved
Hide resolved
...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/assignmentOperation.json
Outdated
Show resolved
Hide resolved
...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/assignmentOperation.json
Outdated
Show resolved
Hide resolved
...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/assignmentOperation.json
Outdated
Show resolved
Hide resolved
...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/assignmentOperation.json
Outdated
Show resolved
Hide resolved
...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/assignmentOperation.json
Outdated
Show resolved
Hide resolved
...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/assignmentOperation.json
Outdated
Show resolved
Hide resolved
...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/assignmentOperation.json
Outdated
Show resolved
Hide resolved
...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/assignmentOperation.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Waiting on service deployment to merge :)
@haitch - Is this API now public? |
@annatisch it is public, you can safely merge this PR. |
@RyanBensonMSFT - could you please sign off your review if your requested changes have been addressed? Adding @lmazuel to merge PR once that sign off happens. |
@RyanBensonMSFT please let us know if anything is blocking the sign off. |
@lmazuel could you merge the PR please? |
* move blueprint from private repo to public * address comment * fat finger * add description in ResourceProviderOperation * camelCase for resourceType * strongType ParameterValueCollection * remove the hacky workaround for extension resource path * init apiVersion=Nov2018 * api definition * progress * split assignment and blueprint definition * assignmentOperation api * split swagger to multiple area for easy upgrade * update suppression due to file split * modeling assignmentOperations * suppress warnings on new file * fix assignmentOperation list * typo * add python repo * add title and description, fix old apiversion in examples * update assignmentOperation use scope for more flexbility * rename blueprintAssignments/operations to blueprintAssignments/assignmentOperations * fix double forward slashes * description update * more capital letters * werid casing error
Changes
Contribution checklist: