Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger specification for Service Fabric runtime version 6.4 #4591

Merged
merged 4 commits into from
Dec 5, 2018
Merged

Swagger specification for Service Fabric runtime version 6.4 #4591

merged 4 commits into from
Dec 5, 2018

Conversation

vipul-modi
Copy link

…-preview release.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Nov 27, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3865

@AutorestCI AutorestCI mentioned this pull request Nov 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4180

@AutorestCI AutorestCI mentioned this pull request Nov 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#569

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Nov 27, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3607

@AutorestCI AutorestCI mentioned this pull request Nov 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 27, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2265

@vipul-modi
Copy link
Author

#sign-off - Ready to merge

@lmazuel
Copy link
Member

lmazuel commented Nov 29, 2018

@AutorestCI regenerate azure-sdk-for-python

@AutorestCI AutorestCI mentioned this pull request Nov 29, 2018
Merged
@Christina-Kang
Copy link

@sarangan12 please let me know if there is anything else required before merging. Otherwise, this is ready to merge. Thank you!

@vipul-modi
Copy link
Author

@sarangan12 or @sergey-shandar can one of you please merge this?

@sarangan12 sarangan12 removed their assignment Dec 3, 2018
@sarangan12 sarangan12 removed their request for review December 3, 2018 21:44
@nschonni
Copy link
Contributor

nschonni commented Dec 3, 2018

Looks like this has some of the same typos as #4528

@azuresdkci azuresdkci requested a review from sarangan12 December 3, 2018 22:44
@vipul-modi
fix typos specificed -> specified, sucessful -> successful, resturns …
c69b3d2 
…-> returns, commited -> committed, Double word "maximum", Double word "with"
@vipul-modi
Copy link
Author

Updated - we generate our Swagger files from multiple files managed by different teams in our repo and this change was missing from there. Going forward it should have this change.

@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@Christina-Kang
Copy link

#sign-off - Ready to merge

@suhuruli
Copy link

suhuruli commented Dec 4, 2018

@sarangan12, can you please help with this or let us know how we can speed this process up?

@vipul-modi
Copy link
Author

@salameer - can you please help us get this published. We are blocked on releasing new SFCTL and Maven CLI.

@sarangan12 sarangan12 merged commit 3c85214 into Azure:master Dec 5, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@AnuTalluri
Swagger specification for Service Fabric runtime version 6.4 (Azure#4591
cb47262 
)

* Swagger specification for Service Fabric runtime version 6.4

* fix typos specificed -> specified, sucessful -> successful, resturns -> returns, commited -> committed, Double word "maximum", Double word "with"

* typo: Parition to Partition

* remove invalid character
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarangan12 sarangan12 sarangan12 approved these changes

Assignees

@sarangan12 sarangan12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vipul-modi @AutorestCI @azuresdkci @lmazuel @Christina-Kang @nschonni @suhuruli @sarangan12