Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContainerServices - OpenShift - Add new routes and update #4597

Merged
merged 4 commits into from
Dec 11, 2018
Merged

ContainerServices - OpenShift - Add new routes and update #4597

merged 4 commits into from
Dec 11, 2018

Conversation

julienstroheker
Copy link
Contributor

  • Add the OpenShiftManagedClusters_ListByResourceGroup + Example
  • OpenShiftManagedClusters_List route + Example
  • Update existing examples
  • Add the new supported SKUs

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

@julienstroheker
Add the OpenShiftManagedClusters_ListByResourceGroup and OpenShiftMan…
4ba2a4e 
…agedClusters_List route + Examples

Update the Examples
Add the new supported SKUs
@AutorestCI AutorestCI mentioned this pull request Nov 28, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3378

@AutorestCI AutorestCI mentioned this pull request Nov 28, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4437

@AutorestCI AutorestCI mentioned this pull request Nov 28, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#816

@AutorestCI AutorestCI mentioned this pull request Nov 28, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2072

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Nov 28, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 28, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3685

@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Nov 29, 2018
Closed
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-python

@AutorestCI AutorestCI mentioned this pull request Nov 29, 2018
Merged
@jhendrixMSFT
Copy link
Member

@lmazuel can you please take a look at the python SDK build failure?

@ravbhatnagar ravbhatnagar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 29, 2018
@lmazuel lmazuel mentioned this pull request Nov 30, 2018
Merged
@julienstroheker
Copy link
Contributor Author

@jhendrixMSFT Any progress on this ? Thanks

@jhendrixMSFT
Copy link
Member

@lmazuel needs to look at the python build failure as it's a blocking issue.

@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Dec 5, 2018
Merged
@jhendrixMSFT
Copy link
Member

Also I see @ravbhatnagar added the WaitForARMFeedback label. Is this still pending review?

@ravbhatnagar
Copy link
Contributor

@RyanBensonMSFT for review from ARM side.

@KrisBash KrisBash added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 6, 2018
KrisBash
KrisBash approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm

@KrisBash KrisBash removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 6, 2018
@jhendrixMSFT
Copy link
Member

Going to close then re-open to see if this fixes CI.

@jhendrixMSFT jhendrixMSFT reopened this Dec 11, 2018
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

This was referenced Dec 11, 2018
Merged
Merged
Merged
@lmazuel lmazuel merged commit 13b129e into Azure:master Dec 11, 2018
@kpajdzik kpajdzik removed the review label Dec 11, 2018
@julienstroheker julienstroheker deleted the containerservice-osa-preview2 branch December 11, 2018 19:19
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@julienstroheker @AnuTalluri
ContainerServices - OpenShift - Add new routes and update (Azure#4597)
df8daac 
* Add the OpenShiftManagedClusters_ListByResourceGroup and OpenShiftManagedClusters_List route + Examples
Update the Examples
Add the new supported SKUs

* Fix API Version in example

* remove private preview count limitations

* Update description to remove min and max limitations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@KrisBash KrisBash KrisBash approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@julienstroheker @AutorestCI @azuresdkci @jhendrixMSFT @ravbhatnagar @KrisBash @lmazuel @kpajdzik