-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] add C# config to readme.md #4896
Conversation
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Is |
``` yaml $(python) && $(python-mode) == 'update' | ||
python: | ||
no-namespace-folders: true | ||
output-folder: $(python-sdks-folder)/azure-mgmt-containerservice/azure/mgmt/containerservice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to name the package containerServices (plural) in C# and containerservice (singular) in python?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should both be singular as that is reflective of the ARM resource name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CIL
Let's revisit this after Azure/azure-sdk-for-python#3378 merges, because that will fix the multi-api CI failure we saw, so maybe changing that config isn't necessary. |
62aeb89
to
cc878ef
Compare
@amarzavery sorry for the thrashing--I think this is reviewable now. (It failed CI because the multi-api config hadn't landed in the Python SDK yet, but @lmazuel fixed that yesterday.) |
* [AKS] add C# config to readme.md * Updating csharp tags and fixing python tags so as to address python sdk breaking changes * Revert some changes now that multi-api should work for python SDK * Add .NET SDK to "Swagger to SDK" auto-PR section
Adds a
--csharp
config for ACS/AKS/OSA. cc: @jskulavik.Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.