Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] add C# config to readme.md #4896

Merged
merged 4 commits into from
Dec 15, 2018

Conversation

mboersma
Copy link
Member

Adds a --csharp config for ACS/AKS/OSA. cc: @jskulavik.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#816

@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4437

@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2230

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@nschonni
Copy link
Contributor

Is - repo: azure-sdk-for-net needed in the swagger-to-sdk: list?

``` yaml $(python) && $(python-mode) == 'update'
python:
no-namespace-folders: true
output-folder: $(python-sdks-folder)/azure-mgmt-containerservice/azure/mgmt/containerservice
Copy link
Contributor

@amarzavery amarzavery Dec 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to name the package containerServices (plural) in C# and containerservice (singular) in python?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should both be singular as that is reflective of the ARM resource name.

Copy link
Contributor

@amarzavery amarzavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIL

@mboersma mboersma changed the title [AKS] add C# config to readme.md [DO NOT MERGE] [AKS] add C# config to readme.md Dec 13, 2018
@mboersma
Copy link
Member Author

Let's revisit this after Azure/azure-sdk-for-python#3378 merges, because that will fix the multi-api CI failure we saw, so maybe changing that config isn't necessary.

@mboersma
Copy link
Member Author

@amarzavery sorry for the thrashing--I think this is reviewable now. (It failed CI because the multi-api config hadn't landed in the Python SDK yet, but @lmazuel fixed that yesterday.)

@amarzavery amarzavery merged commit 72e806d into Azure:master Dec 15, 2018
@kpajdzik kpajdzik removed the review label Dec 15, 2018
@mboersma mboersma deleted the aks-add-csharp-config branch December 17, 2018 17:23
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
* [AKS] add C# config to readme.md

* Updating csharp tags and fixing python tags so as to address python sdk breaking changes

* Revert some changes now that multi-api should work for python SDK

* Add .NET SDK to "Swagger to SDK" auto-PR section
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants