-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding ekg swagger files #4898
adding ekg swagger files #4898
Conversation
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: ['/usr/local/bin/autorest', '/tmp/tmpxj1n1kdt/rest/specification/EnterpriseKnowledgeGraph/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpxj1n1kdt/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.127', '--use-onever', '--verbose'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
Including configuration file 'file:///tmp/tmpxj1n1kdt/rest/specification/EnterpriseKnowledgeGraph/resource-manager/readme.go.md'
Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.127->2.1.127)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-12-03"} .
Including configuration file 'file:///tmp/tmpxj1n1kdt/rest/specification/EnterpriseKnowledgeGraph/resource-manager/readme.go.md'
FATAL: System.InvalidOperationException: codegen for preview swagger Microsoft.EnterpriseKnowledgeGraph/preview/2018-12-03/EnterpriseKnowledgeGraphSwagger.json must be under a preview subdirectory
at AutoRest.Go.CodeGeneratorGo.<Generate>d__6.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 51
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at NewPlugin.<Process>d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2018-12-03"} -- Error: Plugin go reported failure..
Error: Plugin go reported failure. |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
This looks like a new provider. Has this been reviewed in a meeting with ARM? If not, please schedule a review with ARM api review. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments for required changes
specification/ekg/resource-manager/Microsoft.EKG/preview/2018-12-03/ekgSwagger.json
Outdated
Show resolved
Hide resolved
specification/ekg/resource-manager/Microsoft.EKG/preview/2018-12-03/ekgSwagger.json
Outdated
Show resolved
Hide resolved
specification/ekg/resource-manager/Microsoft.EKG/preview/2018-12-03/ekgSwagger.json
Outdated
Show resolved
Hide resolved
specification/ekg/resource-manager/Microsoft.EKG/preview/2018-12-03/ekgSwagger.json
Outdated
Show resolved
Hide resolved
specification/ekg/resource-manager/Microsoft.EKG/preview/2018-12-03/ekgSwagger.json
Outdated
Show resolved
Hide resolved
specification/ekg/resource-manager/Microsoft.EKG/preview/2018-12-03/ekgSwagger.json
Outdated
Show resolved
Hide resolved
@KrisBash Have youe review cmments been resolved? |
Hi, Please review the latest changes. |
Any updates on this pull request? |
specification/EnterpriseKnowledgeGraph/resource-manager/readme.go.md
Outdated
Show resolved
Hide resolved
Issues fixed, please review |
@stanwixxy Seems this is a new RP... can you kindly set up a meeting with the ARM API review board? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates
@stanwixxy I have sent an email to the AzureAPI board to review the PR as well. |
@praries880 What is the SLA for the AzureAPI board review? We must get this out before the end of this month. |
Any updates on this? We set up a meeting earlier with armapireview@microsoft.com. Do we need to set up a different meeting? |
@stanwixxy yes.. this is the alias : azureapirbcore@microsoft.com I already have an email out to them. I haven't heard back as yet. I could not map your git hub alias to a Microsoft alias and hence was not able to add you the email. I have added Mark to it though. |
* adding ekg swagger files * review fixes * review fixes * review fixes * adding go readme file * renaming ekg to EnterpriseKnowledgeGrapg * renaming ekg to EnterpriseKnowledgeGrapg * renaming ekg to EnterpriseKnowledgeGrapg * adding metadata property * adding metadata property * fixing go issues
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.