Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ekg swagger files #4898

Merged
merged 15 commits into from
Jan 25, 2019
Merged

adding ekg swagger files #4898

merged 15 commits into from
Jan 25, 2019

Conversation

stanwixxy
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpxj1n1kdt/rest/specification/EnterpriseKnowledgeGraph/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpxj1n1kdt/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.127', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Including configuration file 'file:///tmp/tmpxj1n1kdt/rest/specification/EnterpriseKnowledgeGraph/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.127->2.1.127)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-12-03"} .
   Including configuration file 'file:///tmp/tmpxj1n1kdt/rest/specification/EnterpriseKnowledgeGraph/resource-manager/readme.go.md'
FATAL: System.InvalidOperationException: codegen for preview swagger Microsoft.EnterpriseKnowledgeGraph/preview/2018-12-03/EnterpriseKnowledgeGraphSwagger.json must be under a preview subdirectory
   at AutoRest.Go.CodeGeneratorGo.<Generate>d__6.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 51
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.<Process>d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2018-12-03"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@praries880 praries880 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. labels Dec 14, 2018
@KrisBash
Copy link
Contributor

This looks like a new provider. Has this been reviewed in a meeting with ARM? If not, please schedule a review with ARM api review. Thanks

@KrisBash KrisBash added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 21, 2018
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for required changes

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed ARMReviewMeetingRequired WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Dec 21, 2018
@praries880
Copy link

@KrisBash Have youe review cmments been resolved?

@stanwixxy
Copy link
Contributor Author

Hi, Please review the latest changes.

@stanwixxy
Copy link
Contributor Author

Any updates on this pull request?

@stanwixxy
Copy link
Contributor Author

Issues fixed, please review

@praries880
Copy link

@stanwixxy Seems this is a new RP... can you kindly set up a meeting with the ARM API review board?

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jan 18, 2019
@praries880 praries880 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 18, 2019
@praries880
Copy link

@stanwixxy I have sent an email to the AzureAPI board to review the PR as well.

@themucha
Copy link

@praries880 What is the SLA for the AzureAPI board review? We must get this out before the end of this month.

@stanwixxy
Copy link
Contributor Author

Any updates on this? We set up a meeting earlier with armapireview@microsoft.com. Do we need to set up a different meeting?

@praries880
Copy link

@stanwixxy yes.. this is the alias : azureapirbcore@microsoft.com

I already have an email out to them. I haven't heard back as yet. I could not map your git hub alias to a Microsoft alias and hence was not able to add you the email. I have added Mark to it though.

@praries880 praries880 removed the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jan 25, 2019
@praries880 praries880 merged commit f1e8ed8 into Azure:master Jan 25, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
* adding ekg swagger files

* review fixes

* review fixes

* review fixes

* adding go readme file

* renaming ekg to EnterpriseKnowledgeGrapg

* renaming ekg to EnterpriseKnowledgeGrapg

* renaming ekg to EnterpriseKnowledgeGrapg

* adding metadata property

* adding metadata property

* fixing go issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants