Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PATCH API example to hanaonazure #4949

Merged
merged 4 commits into from
Dec 22, 2018
Merged

Add PATCH API example to hanaonazure #4949

merged 4 commits into from
Dec 22, 2018

Conversation

AprilZhaoWY
Copy link
Contributor

@AprilZhaoWY AprilZhaoWY commented Dec 19, 2018 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Dec 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#728

@AutorestCI AutorestCI mentioned this pull request Dec 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3277

@AutorestCI AutorestCI mentioned this pull request Dec 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2297

@azuresdkci
Copy link
Contributor

Hello!!

The Rest API Specs team wishes everyone a happy holiday and would like to kindly inform you that responses and review to Pull request will be delayed during the holiday period (now -> 2nds of January) to allow for Awesome reviewers to have an awesome time with their families during the holidays!

Thanks and Have a WONDERFUL HOLIDAY

@AutorestCI AutorestCI mentioned this pull request Dec 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4345

@AutorestCI AutorestCI mentioned this pull request Dec 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3776

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@amarzavery amarzavery assigned amarzavery and unassigned praries880 Dec 21, 2018
amarzavery
amarzavery reviewed Dec 21, 2018
View reviewed changes
Copy link
Contributor

@amarzavery amarzavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please respond to the comments in the PR.

@amarzavery amarzavery merged commit 789256c into Azure:master Dec 22, 2018
@kpajdzik kpajdzik removed the review label Dec 22, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@AprilZhaoWY @AnuTalluri
Add PATCH API example to hanaonazure (Azure#4949)
56f70d4 
* Add PATCH API example to hanaonazure

* Address PR feedback

* Add Tags definiton back

* Change operationId to HanaInstances_Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lagalbra lagalbra lagalbra requested changes

@amarzavery amarzavery amarzavery approved these changes

@praries880 praries880 Awaiting requested review from praries880

Assignees

@amarzavery amarzavery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AprilZhaoWY @AutorestCI @azuresdkci @amarzavery @lagalbra @praries880 @kpajdzik