Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For preview api: Change type of Ssis actitvity to support expression #4986

Merged
merged 1 commit into from
Jan 15, 2019
Merged

For preview api: Change type of Ssis actitvity to support expression #4986

merged 1 commit into from
Jan 15, 2019

Conversation

shawncx
Copy link
Contributor

@shawncx shawncx commented Jan 4, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@msxichen
For preview: Change type of Ssis actitvity's packagePath, runtime, lo…
795e21a 
…ggingLevel and environmentPath from string to object, so that we can use expression for these properties# Please enter the commit message for your changes. Lines starting
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@shawncx shawncx changed the title For preview api: Change type of Ssis actitvity's to use exporession For preview api: Change type of Ssis actitvity's to use expression Jan 4, 2019
@AutorestCI
Copy link

AutorestCI commented Jan 4, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci azuresdkci requested a review from praries880 January 4, 2019 07:09
@AutorestCI
Copy link

AutorestCI commented Jan 4, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2293

@AutorestCI AutorestCI mentioned this pull request Jan 4, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 4, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3865

@AutorestCI AutorestCI mentioned this pull request Jan 4, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 4, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

@AutorestCI
Copy link

AutorestCI commented Jan 4, 2019 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@shawncx shawncx changed the title For preview api: Change type of Ssis actitvity's to use expression For preview api: Change type of Ssis actitvity to support expression Jan 4, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jan 4, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#578

@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 7, 2019
@shawncx
Copy link
Contributor Author

shawncx commented Jan 8, 2019

@hvermis could you help for review? Thanks

@ravbhatnagar
Copy link
Contributor

changing type of properties is a breaking change. You should bump the api-version for this change.

@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 9, 2019
@hvermis
Copy link
Contributor

hvermis commented Jan 9, 2019

@ravbhatnagar the change is from string to object - this is to allow expressions too. Is it still considered breaking? String will still be accepted.

@ravbhatnagar
Copy link
Contributor

I think so, but can someone from SDK team confirm this? May be I am mistaken but will a strongly typed SDK like .NET be able to deserialize this. @praries880 ?

@praries880
Copy link

@ravbhatnagar Ill paste an answer to your query shortly...

@praries880
Copy link

@ravbhatnagar SDK team will accept this change.

KrisBash
KrisBash approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign off for ARM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 15, 2019
@praries880 praries880 merged commit b5e60fe into Azure:master Jan 15, 2019
This was referenced Jan 15, 2019
Merged
Merged
Merged
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@shawncx @AnuTalluri
For preview: Change type of Ssis actitvity's packagePath, runtime, lo…
5019759 
…ggingLevel and environmentPath from string to object, so that we can use expression for these properties# Please enter the commit message for your changes. Lines starting (Azure#4986)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praries880 praries880 praries880 approved these changes

@KrisBash KrisBash KrisBash approved these changes

Assignees

@praries880 praries880

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shawncx @AutorestCI @azuresdkci @ravbhatnagar @hvermis @praries880 @KrisBash @msxichen