Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove webhook activity #5060

Merged
merged 6 commits into from
Jan 18, 2019
Merged

Remove webhook activity #5060

merged 6 commits into from
Jan 18, 2019

Conversation

arsunda
Copy link
Contributor

@arsunda arsunda commented Jan 17, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Jan 17, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci azuresdkci requested a review from praries880 January 17, 2019 22:51
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jan 17, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 17, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

@arsunda
Copy link
Contributor Author

arsunda commented Jan 17, 2019 •
edited
Loading

Removing webhook activity which was added last week, as it is still pending some testing and we want to delay the release till the next cycle @praries880

@AutorestCI AutorestCI mentioned this pull request Jan 17, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 17, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3906

@AutorestCI AutorestCI mentioned this pull request Jan 17, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 17, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

@AutorestCI AutorestCI mentioned this pull request Jan 17, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 17, 2019 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4190

@AutorestCI AutorestCI mentioned this pull request Jan 17, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 17, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#578

@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 17, 2019
@hvermis
Copy link
Contributor

hvermis commented Jan 17, 2019

@praries880 These changes were made too soon, and we need to remove them for our current SDK release. Can you please merge them as soon as you can?

@hvermis
Copy link
Contributor

hvermis commented Jan 17, 2019

To clarify, this a new activities that hasn't been released yet.

@praries880
Copy link

@arsunda Has the .net SDK or (any other SDK) been released with these properties in it?

@salameer
Copy link
Member

@arsunda has the .NEt SDK been released already?

@hvermis
Copy link
Contributor

hvermis commented Jan 17, 2019

@salameer No, these are brand new. We don't want them in the release that we are about to do, hence want them removed from swagger. We will add them for our next release.

@salameer
Copy link
Member

Please note that by sending this Pull request to us you are greenlighting releases of all the SDKs and docs on this swagger and rolling back is not easy or even possible. especially if your adding to the Stable folder

ARM please review this

@salameer
Copy link
Member

If your service is not live you shouldn't publish their spec

@hvermis
Copy link
Contributor

hvermis commented Jan 17, 2019

It was added by mistake. The feature is still in testing stage.

@hvermis
Copy link
Contributor

hvermis commented Jan 17, 2019

@praries880, @salameer Please merge this as soon as you can as this is blocking our SDK release.

@arsunda
Copy link
Contributor Author

arsunda commented Jan 18, 2019

@praries880 @salameer This PR was checked in last week ( #5007 ) . SDK release has not gone out yet, it is scheduled to go out next week. We are still pending some testing results so we do not want release it yet. We want to revert this change so that it does not go into the current release cycle.

KrisBash
KrisBash approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the conversation context, signing off for ARM

@praries880 praries880 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 18, 2019
@praries880 praries880 merged commit 10ce6fb into Azure:master Jan 18, 2019
@praries880
Copy link

@arsunda
We take breaking changes quiet seriously. Even though this is not consumed anywhere, removing properties, API etc form stable swaggers is considered a breaking change. We are merging this change in this once instance but next time onwards cases like this will be reported to the ARM leadership.

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@arsunda @AnuTalluri
Remove webhook activity (Azure#5060)
0517c0c 
* webhook changes

* remove timeout as required

* combine and update web auth definitions

* revert auth type enum change

* removing webhook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvermis hvermis hvermis approved these changes

@KrisBash KrisBash KrisBash approved these changes

@praries880 praries880 Awaiting requested review from praries880

Assignees

@praries880 praries880

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arsunda @AutorestCI @azuresdkci @hvermis @praries880 @salameer @KrisBash