[App Service] Update swagger spec for ANT80 #5111

nking-1 · 2019-01-29T22:53:11Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-portal-comment · 2019-01-29T22:53:13Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2019-01-29T22:53:38Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4079

AutorestCI · 2019-01-29T22:53:43Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#546

AutorestCI · 2019-01-29T22:53:46Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3312

AutorestCI · 2019-01-29T22:54:08Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4153

AutorestCI · 2019-01-29T22:54:21Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2218

AutorestCI · 2019-01-29T22:55:16Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2184

azuresdkci · 2019-01-29T22:57:16Z

Can one of the admins verify this patch?

nschonni

Looks like some spelling fixes are being reverted. Maybe they still need to be fixed in the source code

nschonni · 2019-01-30T02:22:36Z

specification/web/resource-manager/Microsoft.Web/stable/2018-11-01/Certificates.json

@@ -225,7 +225,7 @@
        ],
        "responses": {
          "200": {
-            "description": "Successfully deleted certificate."
+            "description": "Succesfully deleted certificate."


Succesfully -> Successfully

nschonni · 2019-01-30T02:26:24Z

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/Recommendations.json

+          {
+            "name": "recommendationId",
+            "in": "query",
+            "description": "The GUID of the recommedation object if you query an expired one. You don't need to specify it to query an active entry.",


recommedation -> recommendation

nschonni · 2019-01-30T02:28:17Z

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

-            "schema": {
-              "$ref": "./CommonDefinitions.json#/definitions/Operation"
-            }
+            "description": "Succesfully deleted virtual network."


Succesfully -> Successfully

nschonni · 2019-01-30T02:28:27Z

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/WebApps.json

+        ],
+        "responses": {
+          "200": {
+            "description": "Succesfully deleted virtual network."


Succesfully -> Successfully

nschonni · 2019-01-30T02:29:19Z

specification/web/resource-manager/Microsoft.Web/stable/2018-11-01/Certificates.json

@@ -354,7 +354,7 @@
            },
            "expirationDate": {
              "format": "date-time",
-              "description": "Certificate expiration date.",
+              "description": "Certificate expriration date.",


expriration -> expiration

nking-1 · 2019-01-30T19:44:14Z

Looks like some spelling fixes are being reverted. Maybe they still need to be fixed in the source code

Oops, I tried not to copy those over, but it looks like a few got through. Yesterday I combed through the source code to clean up the typos that had been manually fixed in the swagger spec.

sergey-shandar

What's the reason for breaking changes in stable API versions? Usually, we don't allow to do this.

https://travis-ci.org/Azure/azure-rest-api-specs/jobs/486714248

nking-1 · 2019-02-01T01:07:40Z

My previous commits removed the 2018-02-01 Certificates files but I have added them back and that seems to have fixed the breaking changes check.

There is one expected breaking change. There is a property called adminSiteName that's being hidden in this update. Per @suwatch - Admin Site Name feature never released. We should exclude that from rest api documentation as we might get more questions / affects other features.

nking-1 · 2019-02-06T21:00:45Z

@sergey-shandar Is there an ARM team member added to review this PR? This PR has gone dark for about a week now.

sergey-shandar · 2019-02-07T23:46:47Z

@Nking92 because it's potential breaking changes, ARM should review it before I merge. @ravbhatnagar

* Update swagger spec for ANT80 * Fix some spelling errors that were reverted by previous commit * Move certificate examples to new API version folder * Add the 2018-02-01 certificates files back

Update swagger spec for ANT80

3627311

nking-1 requested a review from naveedaz as a code owner January 29, 2019 22:53

azuresdkci assigned sergey-shandar Jan 29, 2019

azuresdkci requested a review from sergey-shandar January 29, 2019 22:53

nschonni reviewed Jan 30, 2019

View reviewed changes

Fix some spelling errors that were reverted by previous commit

5d7bb54

Move certificate examples to new API version folder

f6ebbc8

sergey-shandar added the potential-sdk-breaking-change label Jan 31, 2019

sergey-shandar suggested changes Jan 31, 2019

View reviewed changes

Add the 2018-02-01 certificates files back

78c04a3

This was referenced Feb 1, 2019

[AutoPR web/resource-manager] [App Service] Update swagger spec for ANT80 Azure/azure-sdk-for-go#3988

Merged

[AutoPR web/resource-manager] [App Service] Update swagger spec for ANT80 Azure/azure-sdk-for-java#2898

Closed

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 1, 2019

naveedaz approved these changes Feb 6, 2019

View reviewed changes

sergey-shandar added the ARM-overdue ARM review has not occurred within the expected timeframe label Feb 13, 2019

sergey-shandar approved these changes Feb 13, 2019

View reviewed changes

sergey-shandar merged commit 27361a7 into Azure:master Feb 13, 2019

AutorestCI mentioned this pull request Feb 13, 2019

[AutoPR web/resource-manager] [App Service] Update swagger spec for ANT80 Azure/azure-sdk-for-ruby#2231

Merged

nking-1 mentioned this pull request Feb 14, 2019

Regenerated WebSites SDK for ANT80 REST API spec Azure/azure-sdk-for-net#5244

Merged

9 tasks

naveedaz mentioned this pull request Feb 19, 2019

[App Service] Update swagger spec for ANT80 (#5111) #5228

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[App Service] Update swagger spec for ANT80 #5111

[App Service] Update swagger spec for ANT80 #5111

nking-1 commented Jan 29, 2019 •

edited

Loading

openapi-portal-comment bot commented Jan 29, 2019

AutorestCI commented Jan 29, 2019 •

edited

Loading

AutorestCI commented Jan 29, 2019 •

edited

Loading

AutorestCI commented Jan 29, 2019 •

edited

Loading

AutorestCI commented Jan 29, 2019 •

edited

Loading

AutorestCI commented Jan 29, 2019 •

edited

Loading

AutorestCI commented Jan 29, 2019 •

edited

Loading

azuresdkci commented Jan 29, 2019

nschonni left a comment

nschonni Jan 30, 2019

nschonni Jan 30, 2019

nschonni Jan 30, 2019

nschonni Jan 30, 2019

nschonni Jan 30, 2019

nking-1 commented Jan 30, 2019

sergey-shandar left a comment

nking-1 commented Feb 1, 2019

nking-1 commented Feb 6, 2019

sergey-shandar commented Feb 7, 2019

[App Service] Update swagger spec for ANT80 #5111

[App Service] Update swagger spec for ANT80 #5111

Conversation

nking-1 commented Jan 29, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-portal-comment bot commented Jan 29, 2019

AutorestCI commented Jan 29, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jan 29, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jan 29, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jan 29, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jan 29, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jan 29, 2019 • edited Loading

Automation for azure-sdk-for-ruby

azuresdkci commented Jan 29, 2019

nschonni left a comment

Choose a reason for hiding this comment

nschonni Jan 30, 2019

Choose a reason for hiding this comment

nschonni Jan 30, 2019

Choose a reason for hiding this comment

nschonni Jan 30, 2019

Choose a reason for hiding this comment

nschonni Jan 30, 2019

Choose a reason for hiding this comment

nschonni Jan 30, 2019

Choose a reason for hiding this comment

nking-1 commented Jan 30, 2019

sergey-shandar left a comment

Choose a reason for hiding this comment

nking-1 commented Feb 1, 2019

nking-1 commented Feb 6, 2019

sergey-shandar commented Feb 7, 2019

nking-1 commented Jan 29, 2019 •

edited

Loading

AutorestCI commented Jan 29, 2019 •

edited

Loading

AutorestCI commented Jan 29, 2019 •

edited

Loading

AutorestCI commented Jan 29, 2019 •

edited

Loading

AutorestCI commented Jan 29, 2019 •

edited

Loading

AutorestCI commented Jan 29, 2019 •

edited

Loading

AutorestCI commented Jan 29, 2019 •

edited

Loading