Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Custom Vision 3.0 API #5164

Merged
merged 18 commits into from
Mar 21, 2019
Merged

Add Custom Vision 3.0 API #5164

merged 18 commits into from
Mar 21, 2019

Conversation

areddish
Copy link
Contributor

@areddish areddish commented Feb 6, 2019

Add the 3.0 Versions of Prediction and Training APIs for Custom Vision Cognitive Services

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@areddish areddish requested a review from yangyuan as a code owner February 6, 2019 23:25
@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2353

@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#1702

This was referenced Feb 6, 2019
Closed
Merged
@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#4321

@azuresdkci azuresdkci requested a review from veronicagg February 6, 2019 23:27
@AutorestCI AutorestCI mentioned this pull request Feb 6, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#5016

@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#3007

@AutorestCI AutorestCI mentioned this pull request Feb 6, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@veronicagg veronicagg requested a review from kpajdzik February 6, 2019 23:52
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

yangyuan
yangyuan reviewed Feb 7, 2019
View reviewed changes
Copy link
Member

@yangyuan yangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andrew, have you reviews the 3.0 API with Azure API Review Board Core?

veronicagg
veronicagg suggested changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@areddish thanks for the PR, generally looks good to me. Please let me know when you get approval from the API Review board, so we know we're good on that.
Have these APIs been deployed already?
For SDK code generation, could you update the readme.md files for each of the languages as well? Thanks!

@AutorestCI AutorestCI mentioned this pull request Feb 19, 2019
Closed
@veronicagg
Copy link
Contributor

@areddish will you be making more updates to this PR?

@AutorestCI AutorestCI mentioned this pull request Feb 27, 2019
Closed
This was referenced Mar 14, 2019
Closed
Closed
@shahabhijeet
Copy link
Member

startbuild

@areddish areddish mentioned this pull request Mar 15, 2019
Merged
@dsgouda
Copy link
Contributor

dsgouda commented Mar 18, 2019

Rest spec to Net Sdk automation cannot handle multiple RPs today, please do not block on Automation for azure-sdk-for-net failures for this review

This was referenced Mar 19, 2019
Closed
Closed
This was referenced Mar 20, 2019
Closed
Closed
This was referenced Mar 20, 2019
Closed
Closed
@veronicagg
Copy link
Contributor

@shahabhijeet could you take a look and see why .Net SDK generation is failing? Thanks!

@veronicagg
Copy link
Contributor

ok, I just see a comment from @dsgouda indicating a non supported scenario for .Net SDK, so I'll ignore for this PR.

veronicagg
veronicagg suggested changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple more comments inline. thanks!

This was referenced Mar 21, 2019
Closed
Closed
@AutorestCI AutorestCI mentioned this pull request Mar 21, 2019
Closed
@veronicagg veronicagg merged commit 23d6a7c into Azure:master Mar 21, 2019
@veronicagg veronicagg mentioned this pull request Mar 21, 2019
Closed
5 tasks
@joshfree joshfree mentioned this pull request Sep 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@yangyuan yangyuan yangyuan left review comments

@johanste johanste johanste left review comments

@veronicagg veronicagg veronicagg approved these changes

@kpajdzik kpajdzik kpajdzik approved these changes

@DavidLiCIG DavidLiCIG Awaiting requested review from DavidLiCIG

Assignees

@veronicagg veronicagg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@areddish @AutorestCI @azuresdkci @veronicagg @shahabhijeet @dsgouda @nschonni @yangyuan @johanste @kpajdzik