Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change flag name from useUnifiedSchema into useCommonAlertSchema per … #5323

Merged
merged 1 commit into from
Mar 7, 2019
Merged

change flag name from useUnifiedSchema into useCommonAlertSchema per … #5323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions ...ation/monitor/resource-manager/Microsoft.Insights/stable/2019-03-01/actionGroups_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,9 +504,9 @@
"type": "string",
"description": "The email address of this receiver."
},
"useUnifiedSchema": {
"useCommonAlertSchema": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you guys changing a property name in the existing API version? Did ARM approve this breaking change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we just commit the new api version on 3/1 and this is not use yet, UX guy just started working on the change.
UX raise the request to change the field name on 3/4 , so I raised this pr.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be part of the spec for the new API version then. You cannot introduce breaking changes to a currently stable API version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Then this apiversion 2019-03-01 will never be used. do youm mean create an 2019-03-06？The change is not in RP Prod yet. no one use it now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianghaolu shall we involve the ARM team to review the get some suggestion? This is a urgent fix, we're waiting for approval for RP PROD deployment.

"type": "boolean",
"description": "Indicates whether to use unified schema."
"description": "Indicates whether to use common alert schema."
},
"status": {
"readOnly": true,
Expand All @@ -517,7 +517,7 @@
"required": [
"name",
"emailAddress",
"useUnifiedSchema"
"useCommonAlertSchema"
]
},
"SmsReceiver": {
Expand Down Expand Up @@ -558,15 +558,15 @@
"type": "string",
"description": "The URI where webhooks should be sent."
},
"useUnifiedSchema": {
"useCommonAlertSchema": {
"type": "boolean",
"description": "Indicates whether to use unified schema."
"description": "Indicates whether to use common alert schema."
}
},
"required": [
"name",
"serviceUri",
"useUnifiedSchema"
"useCommonAlertSchema"
]
},
"ItsmReceiver": {
Expand Down Expand Up @@ -645,17 +645,17 @@
"type": "string",
"description": "The URI where webhooks should be sent."
},
"useUnifiedSchema": {
"useCommonAlertSchema": {
"type": "boolean",
"description": "Indicates whether to use unified schema."
"description": "Indicates whether to use common alert schema."
}
},
"required": [
"automationAccountId",
"runbookName",
"webhookResourceId",
"isGlobalRunbook",
"useUnifiedSchema"
"useCommonAlertSchema"
]
},
"VoiceReceiver": {
Expand Down Expand Up @@ -695,16 +695,16 @@
"type": "string",
"description": "The callback url where http request sent to."
},
"useUnifiedSchema": {
"useCommonAlertSchema": {
"type": "boolean",
"description": "Indicates whether to use unified schema."
"description": "Indicates whether to use common alert schema."
}
},
"required": [
"name",
"resourceId",
"callbackUrl",
"useUnifiedSchema"
"useCommonAlertSchema"
]
},
"AzureFunctionReceiver": {
Expand All @@ -726,17 +726,17 @@
"type": "string",
"description": "The http trigger url where http request sent to."
},
"useUnifiedSchema": {
"useCommonAlertSchema": {
"type": "boolean",
"description": "Indicates whether to use unified schema."
"description": "Indicates whether to use common alert schema."
}
},
"required": [
"name",
"functionAppResourceId",
"functionName",
"httpTriggerUrl",
"useUnifiedSchema"
"useCommonAlertSchema"
]
},
"ArmRoleReceiver": {
Expand All @@ -750,15 +750,15 @@
"type": "string",
"description": "The arm role id."
},
"useUnifiedSchema": {
"useCommonAlertSchema": {
"type": "boolean",
"description": "Indicates whether to use unified schema."
"description": "Indicates whether to use common alert schema."
}
},
"required": [
"name",
"roleId",
"useUnifiedSchema"
"useCommonAlertSchema"
]
},
"ReceiverStatus": {
Expand Down
42 changes: 21 additions & 21 deletions ...urce-manager/Microsoft.Insights/stable/2019-03-01/examples/createOrUpdateActionGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
{
"name": "John Doe's email",
"emailAddress": "johndoe@email.com",
"useUnifiedSchema": false
"useCommonAlertSchema": false
},
{
"name": "Jane Smith's email",
"emailAddress": "janesmith@email.com",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"smsReceivers": [
Expand All @@ -38,7 +38,7 @@
{
"name": "Sample webhook",
"serviceUri": "http://www.example.com/webhook",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"itsmReceivers": [
Expand All @@ -64,7 +64,7 @@
"isGlobalRunbook": false,
"name": "testRunbook",
"serviceUri": "https://s13events.azure-automation.net/webhooks?token=iimE%2fD19Eg%2bvDy22yUMecIZY6Uiz%2bHfuQ67r8r1wY%2fI%3d",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"voiceReceivers": [
Expand All @@ -79,7 +79,7 @@
"name": "Sample logicApp",
"resourceId": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/LogicApp/providers/Microsoft.Logic/workflows/testLogicApp",
"callbackUrl": "https://prod-27.northcentralus.logic.azure.com/workflows/68e572e818e5457ba898763b7db90877/triggers/manual/paths/invoke/azns/test?api-version=2016-10-01&sp=%2Ftriggers%2Fmanual%2Frun&sv=1.0&sig=Abpsb72UYJxPPvmDo937uzofupO5r_vIeWEx7KVHo7w",
"useUnifiedSchema": false
"useCommonAlertSchema": false
}
],
"azureFunctionReceivers": [
Expand All @@ -88,14 +88,14 @@
"functionAppResourceId": "/subscriptions/5def922a-3ed4-49c1-b9fd-05ec533819a3/resourceGroups/aznsTest/providers/Microsoft.Web/sites/testFunctionApp",
"functionName": "HttpTriggerCSharp1",
"httpTriggerUrl": "https://testfunctionapp.azurewebsites.net/api/HttpTriggerCSharp1?code=4CopFfiXqUQC8dvIM7F53J7tIU3Gy9QQIG/vKAXMe2avhHqK3/jVYw==",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"armRoleReceivers": [
{
"name": "Sample armRole",
"roleId": "8e3af657-a8ff-443c-a75c-2fe8c4bcb635",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
]
}
Expand All @@ -118,13 +118,13 @@
"name": "John Doe's email",
"emailAddress": "johndoe@email.com",
"status": "Enabled",
"useUnifiedSchema": false
"useCommonAlertSchema": false
},
{
"name": "Jane Smith's email",
"emailAddress": "janesmith@email.com",
"status": "Enabled",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"smsReceivers":[
Expand All @@ -145,7 +145,7 @@
{
"name": "Sample webhook",
"serviceUri": "http://www.example.com/webhook",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"itsmReceivers": [
Expand All @@ -171,7 +171,7 @@
"isGlobalRunbook": false,
"name": "testRunbook",
"serviceUri": "https://s13events.azure-automation.net/webhooks?token=iimE%2fD19Eg%2bvDy22yUMecIZY6Uiz%2bHfuQ67r8r1wY%2fI%3d",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"voiceReceivers": [
Expand All @@ -186,7 +186,7 @@
"name": "Sample logicApp",
"resourceId": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/LogicApp/providers/Microsoft.Logic/workflows/testLogicApp",
"callbackUrl": "https://prod-27.northcentralus.logic.azure.com/workflows/68e572e818e5457ba898763b7db90877/triggers/manual/paths/invoke/azns/test?api-version=2016-10-01&sp=%2Ftriggers%2Fmanual%2Frun&sv=1.0&sig=Abpsb72UYJxPPvmDo937uzofupO5r_vIeWEx7KVHo7w",
"useUnifiedSchema": false
"useCommonAlertSchema": false
}
],
"azureFunctionReceivers": [
Expand All @@ -195,14 +195,14 @@
"functionAppResourceId": "/subscriptions/5def922a-3ed4-49c1-b9fd-05ec533819a3/resourceGroups/aznsTest/providers/Microsoft.Web/sites/testFunctionApp",
"functionName": "HttpTriggerCSharp1",
"httpTriggerUrl": "https://testfunctionapp.azurewebsites.net/api/HttpTriggerCSharp1?code=4CopFfiXqUQC8dvIM7F53J7tIU3Gy9QQIG/vKAXMe2avhHqK3/jVYw==",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"armRoleReceivers": [
{
"name": "Sample armRole",
"roleId": "8e3af657-a8ff-443c-a75c-2fe8c4bcb635",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
]
}
Expand All @@ -224,13 +224,13 @@
"name": "John Doe's email",
"emailAddress": "johndoe@email.com",
"status": "Enabled",
"useUnifiedSchema": false
"useCommonAlertSchema": false
},
{
"name": "Jane Smith's email",
"emailAddress": "janesmith@email.com",
"status": "Enabled",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"smsReceivers":[
Expand All @@ -251,7 +251,7 @@
{
"name": "Sample webhook",
"serviceUri": "http://www.example.com/webhook",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"itsmReceivers": [
Expand All @@ -277,7 +277,7 @@
"isGlobalRunbook": false,
"name": "testRunbook",
"serviceUri": "https://s13events.azure-automation.net/webhooks?token=iimE%2fD19Eg%2bvDy22yUMecIZY6Uiz%2bHfuQ67r8r1wY%2fI%3d",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"voiceReceivers": [
Expand All @@ -292,7 +292,7 @@
"name": "Sample logicApp",
"resourceId": "/subscriptions/187f412d-1758-44d9-b052-169e2564721d/resourceGroups/LogicApp/providers/Microsoft.Logic/workflows/testLogicApp",
"callbackUrl": "https://prod-27.northcentralus.logic.azure.com/workflows/68e572e818e5457ba898763b7db90877/triggers/manual/paths/invoke/azns/test?api-version=2016-10-01&sp=%2Ftriggers%2Fmanual%2Frun&sv=1.0&sig=Abpsb72UYJxPPvmDo937uzofupO5r_vIeWEx7KVHo7w",
"useUnifiedSchema": false
"useCommonAlertSchema": false
}
],
"azureFunctionReceivers": [
Expand All @@ -301,14 +301,14 @@
"functionAppResourceId": "/subscriptions/5def922a-3ed4-49c1-b9fd-05ec533819a3/resourceGroups/aznsTest/providers/Microsoft.Web/sites/testFunctionApp",
"functionName": "HttpTriggerCSharp1",
"httpTriggerUrl": "https://testfunctionapp.azurewebsites.net/api/HttpTriggerCSharp1?code=4CopFfiXqUQC8dvIM7F53J7tIU3Gy9QQIG/vKAXMe2avhHqK3/jVYw==",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"armRoleReceivers": [
{
"name": "Sample armRole",
"roleId": "8e3af657-a8ff-443c-a75c-2fe8c4bcb635",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
]
}
Expand Down
6 changes: 3 additions & 3 deletions ...onitor/resource-manager/Microsoft.Insights/stable/2019-03-01/examples/getActionGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@
"name": "John Doe's email",
"emailAddress": "johndoe@email.com",
"status": "Enabled",
"useUnifiedSchema": true
"useCommonAlertSchema": true
},
{
"name": "Jane Smith's email",
"emailAddress": "janesmith@email.com",
"status": "Disabled",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"smsReceivers": [
Expand All @@ -49,7 +49,7 @@
{
"name": "Sample webhook",
"serviceUri": "http://www.example.com/webhook",
"useUnifiedSchema": false
"useCommonAlertSchema": false
}
]
}
Expand Down
8 changes: 4 additions & 4 deletions ...itor/resource-manager/Microsoft.Insights/stable/2019-03-01/examples/listActionGroups.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@
"name": "John Doe's email",
"emailAddress": "johndoe@email.com",
"status": "Enabled",
"useUnifiedSchema": true
"useCommonAlertSchema": true
},
{
"name": "Jane Smith's email",
"emailAddress": "janesmith@email.com",
"status": "Disabled",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"smsReceivers": [
Expand All @@ -50,7 +50,7 @@
{
"name": "Sample webhook",
"serviceUri": "http://www.example.com/webhook",
"useUnifiedSchema": false
"useCommonAlertSchema": false
}
]
}
Expand All @@ -69,7 +69,7 @@
"name": "John Doe's email",
"emailAddress": "johndoe@email.com",
"status": "Enabled",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"smsReceivers": [
Expand Down
6 changes: 3 additions & 3 deletions ...itor/resource-manager/Microsoft.Insights/stable/2019-03-01/examples/patchActionGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@
"name": "John Doe's email",
"emailAddress": "johndoe@email.com",
"status": "Enabled",
"useUnifiedSchema": true
"useCommonAlertSchema": true
},
{
"name": "Jane Smith's email",
"emailAddress": "janesmith@email.com",
"status": "Enabled",
"useUnifiedSchema": true
"useCommonAlertSchema": true
}
],
"smsReceivers":[
Expand All @@ -55,7 +55,7 @@
{
"name": "Sample webhook",
"serviceUri": "http://www.example.com/webhook",
"useUnifiedSchema": false
"useCommonAlertSchema": false
}
]
}
Expand Down