-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correlation Key property added #5354
Conversation
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
REST Spec PR 'Azure/azure-rest-api-specs#5354' REST Spec PR Author 't-nishab' REST Spec PR Last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are some tab/space indentation issues
Automation for azure-sdk-for-netA PR has been created for you: |
REST Spec PR 'Azure/azure-rest-api-specs#5354' REST Spec PR Author 't-nishab' REST Spec PR Last commit
@orparnes is added to the review. #Closed |
@@ -561,6 +561,11 @@ | |||
"readOnly": true, | |||
"type": "string", | |||
"description": "Azure resource ID of the workspace that the alert was reported to." | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: could you indent this property the same number of spaces as the other properties are?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caused due to the interpretation of tabs to spaces in the ide, fixed now.
@@ -590,7 +590,12 @@ | |||
"readOnly": true, | |||
"type": "string", | |||
"description": "Azure resource ID of the workspace that the alert was reported to." | |||
} | |||
}, | |||
"correlationKey": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: could you fix indenting (same comment as in the other spec)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
REST Spec PR 'Azure/azure-rest-api-specs#5354' REST Spec PR Author 't-nishab' REST Spec PR Last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for addressing the comments.
* .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#5354' REST Spec PR Author 't-nishab' REST Spec PR Last commit * .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#5354' REST Spec PR Author 't-nishab' REST Spec PR Last commit
* .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#5354' REST Spec PR Author 't-nishab' REST Spec PR Last commit * .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#5354' REST Spec PR Author 't-nishab' REST Spec PR Last commit
* .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#5354' REST Spec PR Author 't-nishab' REST Spec PR Last commit * .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#5354' REST Spec PR Author 't-nishab' REST Spec PR Last commit
Added additional property - CorrelationKey to alerts in specification/security/resource-manager/