Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correlation Key property added #5354

Merged
merged 4 commits into from Mar 15, 2019
Merged

Correlation Key property added #5354

merged 4 commits into from Mar 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2019

Added additional property - CorrelationKey to alerts in specification/security/resource-manager/

@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3782

@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#1582

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4288

@AutorestCI
Copy link

AutorestCI commented Mar 10, 2019

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4922

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 10, 2019
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some tab/space indentation issues

@adxsdknet
Copy link

adxsdknet commented Mar 12, 2019

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5404
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@38e3cf4
adxsdknet/azure-sdk-for-net@48674ff

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 12, 2019
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
@orparnes
Copy link
Contributor

@orparnes is added to the review. #Closed

@@ -561,6 +561,11 @@
"readOnly": true,
"type": "string",
"description": "Azure resource ID of the workspace that the alert was reported to."
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: could you indent this property the same number of spaces as the other properties are?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caused due to the interpretation of tabs to spaces in the ide, fixed now.

@@ -590,7 +590,12 @@
"readOnly": true,
"type": "string",
"description": "Azure resource ID of the workspace that the alert was reported to."
}
},
"correlationKey": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: could you fix indenting (same comment as in the other spec)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 14, 2019
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing the comments.

@veronicagg veronicagg merged commit 9f77cfc into Azure:master Mar 15, 2019
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 18, 2019
* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit

* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
chidozieononiwu pushed a commit to chidozieononiwu/azure-sdk-for-net that referenced this pull request Mar 26, 2019
* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit

* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit

* .NET SDK Resource Provider:'SecurityCenter'
REST Spec PR 'Azure/azure-rest-api-specs#5354'
REST Spec PR Author 't-nishab'
REST Spec PR Last commit
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants