Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Search] Add L-Series SKU values to management plane #5386

Merged
merged 1 commit into from
Mar 19, 2019
Merged

[Azure Search] Add L-Series SKU values to management plane #5386

merged 1 commit into from
Mar 19, 2019

Conversation

smaine
Copy link
Contributor

@smaine smaine commented Mar 14, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4503

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1633

@azuresdkci azuresdkci requested a review from sarangan12 March 14, 2019 18:16
@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2267

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#4960

@smaine smaine changed the title Add L-Series SKU values to management plane [Azure Search] Add L-Series SKU values to management plane Mar 14, 2019
@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4315

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@brjohnstmsft
Copy link
Member

@sarangan12 @shahabhijeet The job to generate the .NET SDK failed with errors that don't appear to be related to our changes:

 C:\jenkins\workspace\tmpB3A\src\SDKs\Search\Management\Management.Search\Microsoft.Azure.Management.Search.csproj
11:19:27      1>c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj(17,9): error : InvalidOperationException: Sequence contains more than one element
11:19:27 c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj(17,9): error :    at System.Linq.Enumerable.Single[TSource](IEnumerable`1 source)
11:19:27 c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj(17,9): error :    at MS.Az.SwaggerToSdk.Common.Utilities.SdkForNetRepoDirectoryStructure.FindSdkCsProjFilePath() in D:\myFork\azNetSdkTools\dev\src\SwaggerToSdk\Common\SToS.Common\Utilities\ResourceProviderDirectorySearch.cs:line 284
11:19:27 c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj(17,9): error :    at MS.Az.SwaggerToSdk.UtilTasks.GenerateSdkUtilTask.BuildProject() in D:\myFork\azNetSdkTools\dev\src\SwaggerToSdk\BuildTasks\SToS.BuildTasks\UtilTasks\GenerateSdkUtilTask.cs:line 199
11:19:27 c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj(17,9): error :    at MS.Az.SwaggerToSdk.UtilTasks.GenerateSdkUtilTask.ExecuteTask() in D:\myFork\azNetSdkTools\dev\src\SwaggerToSdk\BuildTasks\SToS.BuildTasks\UtilTasks\GenerateSdkUtilTask.cs:line 147
11:19:27 c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj(17,9): error :    at MS.Az.SwaggerToSdk.BuildTasks.StartNetSdkCodeGeneration.ExecuteInternal() in D:\myFork\azNetSdkTools\dev\src\SwaggerToSdk\BuildTasks\SToS.BuildTasks\BuildTasks\StartNetSdkCodeGeneration.cs:line 104
11:19:27 c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj(17,9): error : 
11:19:27      1>Done Building Project "c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj" (StartNetSdkCodeGeneration target(s)) -- FAILED.
11:19:27 
11:19:27 Build FAILED.
11:19:27 
11:19:27          c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj(3,5): warning : The local source 'c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\tools\LocalNugetFeed' doesn't exist.
11:19:27          c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj(3,5): warning : The local source 'c:\jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\tools\LocalNugetFeed' doesn't exist.

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3059

@dsgouda
Copy link
Contributor

dsgouda commented Mar 18, 2019

@sarangan12 Build failures have been fixed, please approve when ready

@sarangan12 sarangan12 merged commit 13982e5 into Azure:master Mar 19, 2019
This was referenced Mar 19, 2019
Merged
Merged
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@deveshdama @ksapkota-msft
Adding new resource types to Azure Percept RP (#5386)
573cdbe 
* Adding new resource types to Azure Percept RP

* Spell error fix in swagger

* Spell error fix.

* fixing accounts create and update examples

* fix emample for discover sensors

* added custom words in the correct custom-words.txt file for skipping them from checking for spelling error.

* some change for spelling mistakes are overridden bu previous checkin, checking the fix back in.

* Fix prettier issue and some model validation issue.

* Model Validation issues fixed.

* Schema/Model Validation issues fixed.

* Model issues fixed.

* autorest warning fix

* adding format validation for clinentId/ servicePrincipalId as GUID.

* Model Validation issues fixed.

* PR review feedback fixed.

* 201 responses are removed for PUT call as it enforces to implement long running operation flag to true for making it asynchronous. PUT calls are not long running operation for these resources.

* Sensor password property has been changed to x-ms-secret.

* values properties have been added for all x-ms-enum(s) used in RP.

* Removed the modified files package-lock.json and .vscode/settings.json from the pull request.

* provisioningState property has been added in all resource types.

* Added provisionState property in Account resource type.

* Lint warning fixed. Description property for provisioningState has been added.

* component property renamed to componentName

* deviceType and sensorName property removed.

Co-authored-by: Krishna Sapkota <krsapk@microsoft.com>
Co-authored-by: ksapkota-msft <64666908+ksapkota-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarangan12 sarangan12 sarangan12 approved these changes

@brjohnstmsft brjohnstmsft brjohnstmsft approved these changes

Assignees

@sarangan12 sarangan12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@smaine @AutorestCI @azuresdkci @brjohnstmsft @dsgouda @sarangan12