Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert some changes in authoring #5447

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Revert some changes in authoring #5447

merged 1 commit into from
Mar 29, 2019

Conversation

nebadr
Copy link
Contributor

@nebadr nebadr commented Mar 21, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@nebadr nebadr changed the title Revert changes in authoring Revert some changes in authoring Mar 21, 2019
@AutorestCI
Copy link

AutorestCI commented Mar 21, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Mar 21, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 21, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4389

@AutorestCI AutorestCI mentioned this pull request Mar 21, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 21, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1878

@azuresdkci azuresdkci requested a review from anuchandy March 21, 2019 16:28
@AutorestCI AutorestCI mentioned this pull request Mar 21, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 21, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#5007

@AutorestCI AutorestCI mentioned this pull request Mar 21, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 21, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Mar 21, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@dsgouda
Copy link
Contributor

dsgouda commented Mar 22, 2019

startbuild

@dsgouda
Copy link
Contributor

dsgouda commented Mar 22, 2019

@nebadr please join the Azure org on github here to kick off Net Sdk automation build

@nebadr
Copy link
Contributor Author

nebadr commented Mar 25, 2019

@nebadr please join the Azure org on github here to kick off Net Sdk automation build

@dsgouda done.

@dsgouda
Copy link
Contributor

dsgouda commented Mar 25, 2019

startbuild

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 25, 2019
@adxsdknet
.NET SDK Resource Provider:'Authoring'
f73e68e 
REST Spec PR 'Azure/azure-rest-api-specs#5447'
REST Spec PR Author 'nebadr'
REST Spec PR Last commit
@adxsdknet
Copy link

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5572
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@f73e68e

@dsgouda
Copy link
Contributor

dsgouda commented Mar 26, 2019

@nebadr is reverting changes introduced here
@anuchandy will take over this one.

@dsgouda dsgouda assigned dsgouda and unassigned anuchandy Mar 26, 2019
@dsgouda dsgouda removed the request for review from anuchandy March 26, 2019 16:46
dsgouda
dsgouda approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 852d41d into Azure:master Mar 29, 2019
@AutorestCI AutorestCI mentioned this pull request Mar 29, 2019
Merged
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 29, 2019
@adxsdknet @dsgouda
.NET SDK Resource Provider:'Authoring' (#5572)
3231061 
REST Spec PR 'Azure/azure-rest-api-specs#5447'
REST Spec PR Author 'nebadr'
REST Spec PR Last commit
@AutorestCI AutorestCI mentioned this pull request Mar 29, 2019
Merged
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
.NET SDK Resource Provider:'Authoring' (Azure#5572)
0e4e5b4 
REST Spec PR 'Azure/azure-rest-api-specs#5447'
REST Spec PR Author 'nebadr'
REST Spec PR Last commit
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@ajaygit158 @ajaygit158-zz
Added GetSupportedSKU Api and updated the URL to meet RPaaS requireme… (
199bbf8 
#5447)

* Added GetSupportedSKU Api and updated the URL to meet RPaaS requirements.

* Updates.

* Updates.

* Corrections.

* Added appResourceGroup property.

* Updates.

* Updates.

* Updates.

Co-authored-by: Ajay Gupta <ajgupt@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

@DavidLiCIG DavidLiCIG Awaiting requested review from DavidLiCIG

@yangyuan yangyuan Awaiting requested review from yangyuan yangyuan is a code owner

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nebadr @azuresdkci @AutorestCI @dsgouda @adxsdknet @jhendrixMSFT @anuchandy