Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datafactory] Webhook activity #5468

Merged
merged 10 commits into from
Mar 28, 2019
Merged

[Datafactory] Webhook activity #5468

merged 10 commits into from
Mar 28, 2019

Conversation

arsunda
Copy link
Contributor

@arsunda arsunda commented Mar 25, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Mar 25, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4384

@arsunda arsunda changed the title Webhook activity [Datafactory] Webhook activity Mar 25, 2019
@AutorestCI
Copy link

AutorestCI commented Mar 25, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci azuresdkci requested a review from praries880 March 25, 2019 20:43
@AutorestCI AutorestCI mentioned this pull request Mar 25, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 25, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4381

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Mar 25, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 25, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3084

@adxsdknet
Copy link

adxsdknet commented Mar 25, 2019 •
edited
Loading

Automation for azure-sdk-for-net

A PR has been created for you:
https://github.com/azure/azure-sdk-for-net/pull/-1
.NET SDK Commits:
https://github.com/adxsdknet/azure-sdk-for-net/pull/-1/commits/8045a807cc03d80d214053d3875a02cb451db1f8
adxsdknet/azure-sdk-for-net@eb428cb
adxsdknet/azure-sdk-for-net@419ff22
adxsdknet/azure-sdk-for-net@295ca67

@AutorestCI AutorestCI mentioned this pull request Mar 25, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 25, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1833

@arsunda
Copy link
Contributor Author

arsunda commented Mar 25, 2019

@praries880 why is the Automation step failing with 'ApplicationException: Unable to get Pr Number for SDK. Existing...'?

@Azure Azure deleted a comment from adxsdknet Mar 25, 2019
@Azure Azure deleted a comment from adxsdknet Mar 25, 2019
@Azure Azure deleted a comment from adxsdknet Mar 25, 2019
@shahabhijeet
Copy link
Member

@arsunda the spec has issues. The Spec is incomplete and needs to be fixed.
Because when I cloned your branch, I see that it has 4 files changed.
When I generated from your branch (with 4 files changed), the SDK is generated appropriately.

@lmazuel
Copy link
Member

lmazuel commented Mar 26, 2019

@shahabhijeet could you be more specific about what needs to be done in your opinion in order to fix this PR? I don't understand your concerns :(

@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 26, 2019
@lmazuel
Copy link
Member

lmazuel commented Mar 26, 2019

@AutorestCI rebuild azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Mar 26, 2019
Merged
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 27, 2019
@adxsdknet
.NET SDK Resource Provider:'DataFactory'
eb428cb 
REST Spec PR 'Azure/azure-rest-api-specs#5468'
REST Spec PR Author 'arsunda'
REST Spec PR Last commit
@shahabhijeet
Copy link
Member

@lmazuel as discussed in a separate email thread as to why I thought the spec was incorrect.
It turns out we had a bug in our process where 1 file change was not detecting changed generated cs files.
But when tried to reproduce this on a separate repo I got multiple files from this PR, hence thought the spec PR might be missing the files.
So as of now there is no action on the PR author, the bug was in our process and things are running again.

@arsunda
Copy link
Contributor Author

arsunda commented Mar 27, 2019

@praries880 Can you have another look, you can also remove the WaitForArmFeedback label

@praries880
Copy link

@arsunda since you are introducing a new API we do need ARM signoff.

@praries880 praries880 added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Mar 27, 2019
@salameer salameer removed the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Mar 27, 2019
KrisBash
KrisBash approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 27, 2019
@AutorestCI AutorestCI mentioned this pull request Mar 28, 2019
Closed
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 28, 2019
@adxsdknet
.NET SDK Resource Provider:'DataFactory'
419ff22 
REST Spec PR 'Azure/azure-rest-api-specs#5468'
REST Spec PR Author 'arsunda'
REST Spec PR Last commit
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 28, 2019
@adxsdknet
.NET SDK Resource Provider:'DataFactory'
295ca67 
REST Spec PR 'Azure/azure-rest-api-specs#5468'
REST Spec PR Author 'arsunda'
REST Spec PR Last commit
@praries880 praries880 merged commit 80591a0 into Azure:master Mar 28, 2019
@AutorestCI AutorestCI mentioned this pull request Mar 28, 2019
Merged
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 29, 2019
@adxsdknet @dsgouda
AutoPr-DataFactory-arsunda-REST Spec PrNumber 5468 (#5608)
281f5e6 
* .NET SDK Resource Provider:'DataFactory'
REST Spec PR 'Azure/azure-rest-api-specs#5468'
REST Spec PR Author 'arsunda'
REST Spec PR Last commit

* .NET SDK Resource Provider:'DataFactory'
REST Spec PR 'Azure/azure-rest-api-specs#5468'
REST Spec PR Author 'arsunda'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
AutoPr-DataFactory-arsunda-REST Spec PrNumber 5468 (Azure#5608)
9b336e1 
* .NET SDK Resource Provider:'DataFactory'
REST Spec PR 'Azure/azure-rest-api-specs#5468'
REST Spec PR Author 'arsunda'
REST Spec PR Last commit

* .NET SDK Resource Provider:'DataFactory'
REST Spec PR 'Azure/azure-rest-api-specs#5468'
REST Spec PR Author 'arsunda'
REST Spec PR Last commit
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@utkarshjain1508 @pmpMsft
Elastic/2021 10 01 preview (#5468)
e386a56 
* base api commit

* Adding version field to create request, Updating api version fields

* changing version property position

* adding upgrade api for elastic monitor

* Updating Readme

* adding example json

* adding response code

* prettier formatting

* Prettier fix

* addressing review comments

Co-authored-by: Utkarsh Jain <utkarshjain@microsoft.com>
Co-authored-by: pmp <pmp@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@praries880 praries880 praries880 approved these changes

Assignees

@praries880 praries880

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@arsunda @AutorestCI @azuresdkci @adxsdknet @shahabhijeet @lmazuel @praries880 @KrisBash @salameer