Multiapi sync with master and update to latest-profile script

.gitattributes

@@ -0,0 +1,2 @@
+# Set the default behavior, in case people don't have core.autocrlf set.
+* text=auto

.gitignore

@@ -76,7 +76,6 @@ SdkCodeGen
 # Visual Studio #
 .settings/
 .vs/
-.vscode/
 /app.js
 *.suo
 *.user
@@ -105,4 +104,14 @@ output/*
 errors.txt
 warnings.txt
 
-/dist/
+# VS Code files
+.vscode/*
+!.vscode/settings.json
+!.vscode/tasks.json
+!.vscode/launch.json
+!.vscode/extensions.json
+
+*.js
+*.d.ts
+*.js.map
+*.d.ts.map

.travis.yml

@@ -1,3 +1,4 @@
+dist: xenial
 language: node_js
 node_js:
   - '10'
@@ -7,18 +8,13 @@ services:
 env:
   matrix:
     - MODE=branchStrategy
-    - MODE=syntax CHECK_NAME="Syntax Validator"
     - MODE=semantic PR_ONLY=true CHECK_NAME="Semantic Validator"
-    - MODE=semantic PR_ONLY=false
     - MODE=model PR_ONLY=true CHECK_NAME="Model Validator"
-    # - MODE=model PR_ONLY=false
     - MODE=BreakingChange PR_ONLY=true CHECK_NAME="Breaking Changes"
     - MODE=lintdiff PR_ONLY=true CHECK_NAME="Linter Diff" NODE_OPTIONS=--max-old-space-size=8192
 matrix:
   fast_finish: true
   allow_failures:
-    - env: MODE=semantic PR_ONLY=false
-    - env: MODE=model PR_ONLY=false
     - env: MODE=model PR_ONLY=true CHECK_NAME="Model Validator"
     - env: MODE=BreakingChange PR_ONLY=true CHECK_NAME="Breaking Changes"
 install: true
@@ -28,30 +24,29 @@ script:
       # Check to ensure CI is not executing for a PR against the master branch in the private repository
       ! [[ $TRAVIS_PULL_REQUEST != 'false' && $TRAVIS_REPO_SLUG == 'Azure/azure-rest-api-specs-pr' && $TRAVIS_BRANCH == 'master' ]]
     fi
-  - >-
-    if [[ $MODE == 'syntax' ]]; then
-      npm install
-      npm test -- test/syntax.js
-    fi
   - >-
     if [[ $MODE == 'semantic' ]]; then
       npm install
+      npm run tsc
       node scripts/semanticValidation.js
     fi
   - >-
     if [[ $MODE == 'model' ]]; then
       npm install
+      npm run tsc
       node scripts/modelValidation.js
     fi
   - >-
     if [[ $MODE == 'BreakingChange' ]]; then
       scripts/install-dotnet.sh
       npm install
-      node -- scripts/breaking-change.js
+      npm run tsc
+      node scripts/breaking-change.js
     fi
   - >-
     if [[ $MODE == 'lintdiff' ]]; then
       scripts/install-dotnet.sh
       npm install
+      npm run tsc
       node scripts/momentOfTruth.js && node scripts/momentOfTruthPostProcessing.js
-    fi
+    fi

.vscode/launch.json

@@ -0,0 +1,27 @@
+{
+  // Use IntelliSense to learn about possible attributes.
+  // Hover to view descriptions of existing attributes.
+  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+  "version": "0.2.0",
+  "configurations": [
+    {
+      "type": "node",
+      "request": "launch",
+      "name": "Mocha Tests",
+      "program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
+      "args": [
+        "--timeout",
+        "999999",
+        "--colors",
+        "${workspaceFolder}/test/syntax.js"
+      ],
+      "internalConsoleOptions": "openOnSessionStart"
+    },
+    {
+      "type": "node",
+      "request": "launch",
+      "name": "Launch Program",
+      "program": "${file}"
+    }
+  ]
+}

CODEOWNERS

@@ -29,7 +29,7 @@
 /specification/eventgrid/ @kalyanaj
 /specification/eventhub/ @v-ajnava
 /specification/features/ @stankovski
-/specification/graphrbac/ @stankovski
+/specification/graphrbac/ @lmazuel @yugangw-msft @amarzavery
 /specification/hdinsight/ @pulkittomar @wawon-msft
 /specification/insights/ @gucalder
 /specification/intune/ @vrmurthy01

azure-pipelines.yml

@@ -41,7 +41,7 @@ jobs:
     displayName: 'npm install'
     inputs:
       verbose: false
-  - script: 'node scripts/semanticValidation.js'
+  - script: 'npm run tsc && node scripts/semanticValidation.js'
     displayName: 'Semantic Validation'
 
 - job: "ModelValidation"
@@ -52,37 +52,34 @@ jobs:
     displayName: 'npm install'
     inputs:
       verbose: false
-  - script: 'node scripts/modelValidation.js'
+  - script: 'npm run tsc && node scripts/modelValidation.js'
     displayName: 'Model Validation'
 
 - job: "Avocado"
   pool:
     vmImage: 'Ubuntu 16.04'
-  continueOnError: true
   steps:
   - task: Npm@1
     displayName: 'npm install'
     inputs:
       verbose: false
-  - script: './node_modules/.bin/ts-node scripts/avocado.ts'
+  - script: './node_modules/.bin/avocado'
     displayName: 'Avocado'
 
 - job: "BreakingChange"
-  condition: "not(variables['PRIVATE'])"
   pool:
     vmImage: 'Ubuntu 16.04'
   steps:
   - script: 'scripts/install-dotnet.sh'
-    displayName: 'Insall .Net'
+    displayName: 'Install .Net'
   - task: Npm@1
     displayName: 'npm install'
     inputs:
       verbose: false
-  - script: 'node scripts/breaking-change.js'
+  - script: 'npm run tsc && node scripts/breaking-change.js'
     displayName: 'Breaking Changes'
 
 - job: "LintDiff"
-  condition: "not(variables['PRIVATE'])"
   variables:
     NODE_OPTIONS: '--max-old-space-size=8192'
   pool:
@@ -94,7 +91,7 @@ jobs:
       verbose: false
   - script: 'scripts/install-dotnet.sh'
     displayName: 'install .Net'
-  - script: 'node scripts/momentOfTruth.js && node scripts/momentOfTruthPostProcessing.js'
+  - script: 'npm run tsc && node scripts/momentOfTruth.js && node scripts/momentOfTruthPostProcessing.js'
     displayName: 'LintDiff'
 
 - job: "SDK"
@@ -127,3 +124,42 @@ jobs:
   - script: echo $(NODE_OPTIONS)
   - script: "scripts/swagger-to-sdk.sh Azure/$(AZURE_SDK_REPO) -v $(AZURE_SDK_PARAMS)"
     displayName: "Swagger to SDK script"
+
+- job: "NetworkValidation"
+  condition: and(startsWith(variables['System.PullRequest.TargetBranch'], 'network-'), endsWith(variables['System.PullRequest.TargetBranch'], '-release'))
+  continueOnError: true
+  pool:
+    vmImage: vs2017-win2016
+  variables:
+    NRP_SWAGGER_VALIDATION_OVERRIDE_PS_BRANCH: 'true'
+    NRP_BUILD_TOOLS_SKIP_GENERATE_PS1: 'true'
+    NRP_BUILD_TOOLS_OUTPUT_PATH: '$(System.DefaultWorkingDirectory)\Out'
+  steps:
+  - powershell: |
+      & "C:/Program Files (x86)/Microsoft SDKs/Windows/v10.0A/bin/NETFX 4.6.1 Tools/sn.exe" -Vr *,31bf3856ad364e35
+    displayName: Bypass Strong Name validation
+  - task: NodeTool@0
+    inputs:
+      versionSpec: 10.x
+    displayName: Install Node.js
+  - script: npm install autorest -g
+    displayName: Install autorest
+  - script: git clone --depth 1 -- https://dev.azure.com/v-anevse/BuildScripts/_git/BuildScripts ..\BuildScripts
+    displayName: Clone build tools
+  - powershell: |
+      $swgrPath = (Get-Item ".\").FullName
+      $outputPath = $env:NRP_BUILD_TOOLS_OUTPUT_PATH
+      New-Item -Path $outputPath -ItemType "Directory" -Force | Out-Null
+      ..\BuildScripts\Test-SwaggerRelease.ps1 -Component Network -SwaggerRepoPath $swgrPath -OutputFolder $outputPath
+    failOnStderr: false
+    displayName: Test Swagger updates
+  - powershell: |
+      Copy-Item "..\BuildScripts\.azure-pipelines\.artifactignore" -Destination "$($env:NRP_BUILD_TOOLS_OUTPUT_PATH)\.artifactignore" -Force -ErrorAction "SilentlyContinue"
+    failOnStderr: false
+    condition: always()
+    displayName: Copy .artifactignore
+  - task: PublishPipelineArtifact@0
+    condition: always()
+    inputs:
+      artifactName: SwaggerTestOutput
+      targetPath: $(NRP_BUILD_TOOLS_OUTPUT_PATH)

documentation/swagger-checklist.md

@@ -1,4 +1,4 @@
-# Swagger Checklist for Microsoft Azure #
+# Swagger Checklist for Microsoft Azure #
 
 ## Introduction ##
 

package.json

@@ -10,30 +10,31 @@
   "description": "Tests for Azure REST API Specifications",
   "license": "MIT",
   "devDependencies": {
-    "@azure/avocado": "^0.2.2",
-    "@azure/oad": "^0.3.0",
-    "@microsoft.azure/async-io": "^1.0.21",
-    "@microsoft.azure/literate": "^1.0.21",
-    "@microsoft.azure/polyfill": "^1.0.17",
-    "@ts-common/commonmark-to-markdown": "^1.1.10",
-    "@ts-common/fs": "0.1.1",
-    "@types/js-yaml": "^3.12.0",
-    "fs-extra": "^3.0.1",
-    "glob": "^5.0.14",
-    "js-yaml": "^3.13.0",
-    "json-schema-ref-parser": "^3.1.2",
+    "@azure/avocado": "^0.4.1",
+    "@azure/oad": "^0.6.3",
+    "@azure/rest-api-specs-scripts": "^0.2.21",
+    "@microsoft.azure/async-io": "^2.0.21",
+    "@microsoft.azure/literate": "^1.0.25",
+    "@microsoft.azure/polyfill": "^1.0.19",
+    "@octokit/rest": "^16.25.0",
+    "@ts-common/commonmark-to-markdown": "^1.2.0",
+    "@ts-common/fs": "0.2.0",
+    "@types/fs-extra": "^5.0.5",
+    "@types/js-yaml": "^3.12.1",
+    "@types/request": "^2.48.1",
+    "fs-extra": "^7.0.1",
+    "glob": "^7.1.3",
+    "js-yaml": "^3.13.1",
+    "json-schema-ref-parser": "^6.1.0",
     "mocha": "*",
-    "oav": "^0.14.8",
-    "request": "^2.61.0",
-    "request-promise-native": "^1.0.5",
+    "oav": "^0.18.1",
+    "request": "^2.88.0",
+    "request-promise-native": "^1.0.7",
+    "ts-node": "^8.1.0",
+    "typescript": "^3.4.3",
     "compare-versions": "^3.4.0",
     "semver": "^6.0.0",
-    "ts-node": "^8.0.3",
-    "typescript": "^3.2.4",
-    "z-schema": "^3.25.1"
-  },
-  "dependencies": {
-    "@octokit/rest": "^15.2.6"
+    "z-schema": "^4.0.2"
   },
   "homepage": "https://github.com/azure/azure-rest-api-specs",
   "repository": {
@@ -44,7 +45,7 @@
     "url": "http://github.com/azure/azure-rest-api-specs/issues"
   },
   "scripts": {
-    "test": "mocha -t 500000 --reporter min",
+    "test": "tsc && mocha -t 500000 --reporter min",
     "oav": "oav",
     "tsc": "tsc",
     "multiapi": "ts-node ./scripts/multiapi.ts",