Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datafactory] Add three new connectors #6607

Merged
merged 2 commits into from
Jul 17, 2019
Merged

[Datafactory] Add three new connectors #6607

merged 2 commits into from
Jul 17, 2019

Conversation

davidzhaoyue
Copy link
Contributor

@davidzhaoyue davidzhaoyue commented Jul 12, 2019 •
edited
Loading

Latest improvements:

Added three new connectors

  1. Salesforce Service Cloud
  2. Informix
  3. Microsoft Access

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci azuresdkci requested a review from raych1 July 12, 2019 11:24
@AutorestCI AutorestCI mentioned this pull request Jul 12, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 12, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI AutorestCI mentioned this pull request Jul 12, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 12, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5269

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jul 12, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 12, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3084

@nschonni
Copy link
Contributor

You can add Informix to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt so the Spellcheck passes

@davidzhaoyue
Copy link
Contributor Author

You can add Informix to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt so the Spellcheck passes

Done. Thanks!

@raych1 raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 13, 2019
KrisBash
KrisBash approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please make sure no secrets are returned in GET responses by the service

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 16, 2019
@raych1 raych1 merged commit 86b1eee into Azure:master Jul 17, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@davidzhaoyue @celikcigdem
[Datafactory] Add three new connectors (Azure#6607)
cb81ca2 
* [Datafactory] Add three new connectors

* Add Informix into custom-words.txt
@hvermis hvermis mentioned this pull request Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raych1 raych1 raych1 approved these changes

@KrisBash KrisBash KrisBash approved these changes

Assignees

@raych1 raych1

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davidzhaoyue @AutorestCI @azuresdkci @nschonni @KrisBash @raych1