Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data connector kinds AzureAdvancedThreatProtection and MicrosoftDefenderAdvancedThreatProtection. #6614

Merged
merged 8 commits into from
Jul 18, 2019

Conversation

roherzbe
Copy link
Contributor

@roherzbe roherzbe commented Jul 14, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Sorry, something went wrong.

roherzbe added 2 commits July 11, 2019 16:39
… AzureAdvancedThreatProtection) and added discovery logs to MicrosoftCloudAppSecurity.
@roherzbe roherzbe changed the title Add data connector kinds AzureAdvancedThreatProtection and MicrosoftDefenderAdvancedThreatProtection. Add discovery logs to MicrosoftCloudAppSecurity. Add data connector kinds AzureAdvancedThreatProtection and MicrosoftDefenderAdvancedThreatProtection. Jul 14, 2019
@AutorestCI
Copy link

AutorestCI commented Jul 14, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5722

@AutorestCI
Copy link

AutorestCI commented Jul 14, 2019

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 241, in generate_sdk_from_git_object
    raise ValueError("Unable to locate configuration in {}".format(branch_list))
ValueError: Unable to locate configuration in ['restapi_auto_securityinsights/resource-manager', 'restapi_auto_6614', 'master']

@AutorestCI
Copy link

AutorestCI commented Jul 14, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5289

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@roherzbe
Copy link
Contributor Author

roherzbe commented Jul 14, 2019 via email

roherzbe added 2 commits July 14, 2019 13:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nschonni
Copy link
Contributor

You can also add the acronyms to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt if you want to use them

roherzbe added 2 commits July 15, 2019 09:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@roherzbe
Copy link
Contributor Author

@nschonni Thanks for the comment :)
Added to custom-words and updated SecurityInsights.json accordingly.
Waiting for your approve.

@michaeljqzq michaeljqzq added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 15, 2019
roherzbe added 2 commits July 16, 2019 15:07

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 16, 2019
@roherzbe
Copy link
Contributor Author

@michaeljqzq @nschonni
ARM approved :) back to you

@michaeljqzq michaeljqzq merged commit 76c353d into Azure:master Jul 18, 2019
leni-msft pushed a commit to leni-msft/azure-rest-api-specs that referenced this pull request May 13, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>
pathuang-sia pushed a commit that referenced this pull request Oct 26, 2022
* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>
xiaoxuqi-ms pushed a commit that referenced this pull request Nov 15, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ft.AzureStackHCI-2021-09-01-preview' (#21296)

* Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* resolve conflicts

* [Microsoft.AzureStackHCI] 2021-09-01-preview update (#7147)

* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Add canceled to provisioningState enum

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* cherry-pick merge conflict resolution

* storage container changes (#6614)

* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Change hybrididentitymetadata vmid to resourceUid (#4921)

* change hybrididentitymetadata vmid to resourceUid

* update examples

* fix missed merging changes

* cherry-pick merge conflict resolution

* remove 2022-09-01 examples

* git difftool align differences with RPSaaSMaster

* spellcheck fix

* breaking change cross version fix

* fix version

* fix custom word typo

* fix default tag to 2022-10

* address description and example feedback

* address swagger modelvalidation errors

* missed linter and model validation error

* prettier fix

* fixing breaking change errors

* backport common.json from 2021-07-01-preview

* prettier on common.json

* replace Idenitty from v2 definitions

* fix property bag capitalization

* Add missed capitalization modifications

* Add missed semantic fix

* Add missed semantic fix

* revert property definition capitalization according to reviewer feedback

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>
Co-authored-by: aeweston-msft <59626096+aeweston-msft@users.noreply.github.com>
anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
…ft.AzureStackHCI-2021-09-01-preview' (Azure#21296)

* Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* resolve conflicts

* [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147)

* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (Azure#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (Azure#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Add canceled to provisioningState enum

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* cherry-pick merge conflict resolution

* storage container changes (Azure#6614)

* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Change hybrididentitymetadata vmid to resourceUid (Azure#4921)

* change hybrididentitymetadata vmid to resourceUid

* update examples

* fix missed merging changes

* cherry-pick merge conflict resolution

* remove 2022-09-01 examples

* git difftool align differences with RPSaaSMaster

* spellcheck fix

* breaking change cross version fix

* fix version

* fix custom word typo

* fix default tag to 2022-10

* address description and example feedback

* address swagger modelvalidation errors

* missed linter and model validation error

* prettier fix

* fixing breaking change errors

* backport common.json from 2021-07-01-preview

* prettier on common.json

* replace Idenitty from v2 definitions

* fix property bag capitalization

* Add missed capitalization modifications

* Add missed semantic fix

* Add missed semantic fix

* revert property definition capitalization according to reviewer feedback

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>
Co-authored-by: aeweston-msft <59626096+aeweston-msft@users.noreply.github.com>
kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
…ft.AzureStackHCI-2021-09-01-preview' (Azure#21296)

* Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* resolve conflicts

* [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147)

* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (Azure#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (Azure#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Add canceled to provisioningState enum

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* cherry-pick merge conflict resolution

* storage container changes (Azure#6614)

* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Change hybrididentitymetadata vmid to resourceUid (Azure#4921)

* change hybrididentitymetadata vmid to resourceUid

* update examples

* fix missed merging changes

* cherry-pick merge conflict resolution

* remove 2022-09-01 examples

* git difftool align differences with RPSaaSMaster

* spellcheck fix

* breaking change cross version fix

* fix version

* fix custom word typo

* fix default tag to 2022-10

* address description and example feedback

* address swagger modelvalidation errors

* missed linter and model validation error

* prettier fix

* fixing breaking change errors

* backport common.json from 2021-07-01-preview

* prettier on common.json

* replace Idenitty from v2 definitions

* fix property bag capitalization

* Add missed capitalization modifications

* Add missed semantic fix

* Add missed semantic fix

* revert property definition capitalization according to reviewer feedback

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>
Co-authored-by: aeweston-msft <59626096+aeweston-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants