Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ADX Command #6667

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Introduce ADX Command #6667

merged 2 commits into from
Jul 23, 2019

Conversation

tomersh26
Copy link
Contributor

@tomersh26 tomersh26 commented Jul 18, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 18, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 37671c3, Iteration 7)

Failed Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • Failed sdk/datafactory/azure-mgmt-datafactory [Logs]
In-Progress Java: Azure/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: Azure/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: Azure/azure-sdk-for-js [Logs]
  • Package generation in progress.

@msftclas
Copy link

msftclas commented Jul 18, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@AutorestCI AutorestCI mentioned this pull request Jul 18, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 18, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI AutorestCI mentioned this pull request Jul 18, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 18, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5312

@AutorestCI AutorestCI mentioned this pull request Jul 18, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 18, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3084

@azuresdkci azuresdkci requested a review from michaeljqzq July 18, 2019 13:26
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

michaeljqzq
michaeljqzq reviewed Jul 19, 2019
View reviewed changes
...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json Outdated
"properties": {
"command": {
"type": "object",
"description": "A control command, according to the ADX command syntax. Type: string (or Expression with resultType string)."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the command property a string or object?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is eventually a string, but also accepts an Expression which is compiled into a string in the backend. Expression is another type and since we need both to be accepted here (oneOf model from swagger 3.0) we use object type in all these type of properties.

@hvermis
Copy link
Contributor

hvermis commented Jul 19, 2019

@michaeljqzq Can we get this merged today, please? Will be good to have this too in this PS release

@hvermis
Copy link
Contributor

hvermis commented Jul 22, 2019

Hi @michaeljqzq, can we get this merged please?

@michaeljqzq michaeljqzq merged commit 93a6ba1 into Azure:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljqzq michaeljqzq michaeljqzq left review comments

@hvermis hvermis hvermis approved these changes

Assignees

@michaeljqzq michaeljqzq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomersh26 @msftclas @AutorestCI @azuresdkci @hvermis @michaeljqzq