Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HDInsight] Change accessModes and applicationType from enum to string #6785

Merged
merged 1 commit into from
Jul 31, 2019
Merged

[HDInsight] Change accessModes and applicationType from enum to string #6785

merged 1 commit into from
Jul 31, 2019

Conversation

aim-for-better
Copy link
Member

@aim-for-better aim-for-better commented Jul 30, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Problem: in previous pr Azure#6665 we modify accessModes and applicat…
18e8f73 
…ionType to enum, this will bring breaking change in java sdk. Solution: remove the two enum, change it to string type
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 18e8f73, Iteration 2)

Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@aim-for-better aim-for-better requested a review from anuchandy July 30, 2019 06:16
@AutorestCI AutorestCI mentioned this pull request Jul 30, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 30, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6082

@AutorestCI AutorestCI mentioned this pull request Jul 30, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 30, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5396

This was referenced Jul 30, 2019
Merged
Merged
Merged
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@aim-for-better
Copy link
Member Author

Can one of the admins verify this patch?

Hi @anuchandy , could you please help us review this PR?

@anuchandy anuchandy merged commit b9db593 into Azure:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aim-for-better @AutorestCI @azuresdkci @anuchandy