[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 #6995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Testing, Please Ignore[Logs] (Generated from a654615, Iteration 8)
|
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
This was referenced Aug 19, 2019
yaohaizh
added
the
WaitForARMFeedback
nschonni
reviewed
Aug 20, 2019
...cation/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/reservations.json
Outdated
Show resolved
Hide resolved
...cation/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/reservations.json
Outdated
Show resolved
Hide resolved
...cation/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/reservations.json
Outdated
Show resolved
Hide resolved
...cation/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/reservations.json
Outdated
Show resolved
Hide resolved
...cation/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/reservations.json
Outdated
Show resolved
Hide resolved
nschonni
reviewed
Aug 20, 2019
| } | ||
| ], | ||
| "tags": [ | ||
| "Reservation, AvailableScopes" |
There was a problem hiding this comment.
Note sure if these are supposed to be separate tags
Suggested change
| "Reservation, AvailableScopes" | |
| "Reservation", "AvailableScopes" |
There was a problem hiding this comment.
Not sure, but I checked the format of our previous swagger. Same as what I put.
There was a problem hiding this comment.
Let me know if I need to change this format.
There was a problem hiding this comment.
Sorry, one of the SDK/ARM folks would need to make that call. I just noticed that it looked a little odd
|
Signing off from ARM side (new POST /availableScopes API). |
ravbhatnagar
added
ARMSignedOff
yaohaizh
approved these changes
Aug 25, 2019
yaohaizh
approved these changes
Aug 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: