Adding SQL managedDatabases swagger for API v2018-06-01-preview #7172

misosic-msft · 2019-09-10T17:14:21Z

Adding SQL managedDatabases swagger and examples for API version 2018-06-01-preview

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Adding managedDatabases swagger and examples for API version 2018-06-01-preview

openapi-sdkautomation · 2019-09-10T17:14:24Z

In Testing, Please Ignore

[Logs] (Generated from 65fd128, Iteration 10)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

No packages generated.

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-sql [Logs] [Instructions] [Generation PR]
- azure-mgmt-sql-0.13.0.zip
- azure_mgmt_sql-0.13.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

sql/resource-manager/v2014_04_01 [Logs] [Instructions]
sql/resource-manager/v2015_05_01_preview [Logs]
sql/resource-manager/v2017_03_01_preview [Logs]
sql/resource-manager/v2017_10_01_preview [Logs]
sql/resource-manager/v2018_06_01_preview [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/sql/mgmt/2015-05-01-preview [Logs]
preview/sql/mgmt/2017-03-01-preview [Logs]
preview/sql/mgmt/2017-10-01-preview [Logs]
preview/sql/mgmt/2018-06-01-preview [Logs]
sql/mgmt/2014-04-01 [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-sql [Logs] [Instructions]
- azure-arm-sql-5.7.0.tgz

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

AutorestCI · 2019-09-10T17:16:40Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7330

AutorestCI · 2019-09-10T17:18:23Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5805

azuresdkci · 2019-09-10T18:00:59Z

Can one of the admins verify this patch?

…/azure-rest-api-specs into sqlManagedDatabases

…sic-msft/azure-rest-api-specs into sqlManagedDatabases" This reverts commit 86d4b32, reversing changes made to ea47286.

misosic-msft · 2019-09-11T10:14:06Z

I've run autorest validation and got the following:

1st, 3rd and 4th are already present in version 2017-03-01-preview of managedDatabases swagger.
For the 2nd warning, restoreDetails is always a single resource. Can we override this warning and skip implementing List?

michaeljqzq · 2019-09-12T05:23:58Z

WARNING is not required to be fixed. But I see there's some error in semantic validation: 'internal error: Failed to load a reference file specification/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/examples/CompleteManagedRestore.json. (Error: ENOENT: no such file or directory
Please confirm

This reverts commit fab8d36.

misosic-msft · 2019-09-12T21:54:24Z

WARNING is not required to be fixed. But I see there's some error in semantic validation: 'internal error: Failed to load a reference file specification/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/examples/CompleteManagedRestore.json. (Error: ENOENT: no such file or directory
Please confirm

Added the missing file and resolved the validation test failures.

michaeljqzq · 2019-09-16T06:20:00Z

I added the DoNotMerge tag since the title. Do you have a timeline for the PR to merge?

misosic-msft · 2019-09-16T19:07:37Z

I added the DoNotMerge tag since the title. Do you have a timeline for the PR to merge?

Changes for this API are already being rolled out to Production so it can be merged right away if everything looks good. I've removed [DO NOT MERGE] from the title.

misosic-msft · 2019-09-17T21:01:37Z

@michaeljqzq @jaredmoo Can this PR be merged?

Adding managedDatabases swagger

6e5f39e

Adding managedDatabases swagger and examples for API version 2018-06-01-preview

misosic-msft requested a review from jaredmoo as a code owner September 10, 2019 17:14

azuresdkci assigned michaeljqzq Sep 10, 2019

azuresdkci requested a review from michaeljqzq September 10, 2019 17:15

misosic-msft added 3 commits September 11, 2019 11:56

Adding examples for ManagedDatabases swagger

ea47286

Merge branch 'sqlManagedDatabases' of https://github.com/misosic-msft…

86d4b32

…/azure-rest-api-specs into sqlManagedDatabases

Revert "Merge branch 'sqlManagedDatabases' of https://github.com/miso…

b90eaf3

…sic-msft/azure-rest-api-specs into sqlManagedDatabases" This reverts commit 86d4b32, reversing changes made to ea47286.

openapi-sdkautomation bot mentioned this pull request Sep 11, 2019

[AutoPR sql/resource-manager/v2014_04_01] [DO NOT MERGE] Adding SQL managedDatabases swagger for API v2018-06-01-preview test-repo-billy/azure-sdk-for-java#379

Closed

misosic-msft added 2 commits September 12, 2019 14:32

Adding missing ManagedDatabaseCompleteExternalRestore example

d18e4e6

Fixing PR validation errors

9402dbf

misosic-msft added 5 commits September 12, 2019 22:34

Update ManagedDatabaseDelete.json

fab8d36

Update custom-words.txt

2e9169e

Update custom-words.txt

cecae24

Revert "Update ManagedDatabaseDelete.json"

d4a8cd1

This reverts commit fab8d36.

Update ManagedDatabaseDelete.json

65fd128

michaeljqzq approved these changes Sep 16, 2019

View reviewed changes

michaeljqzq added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 16, 2019

misosic-msft changed the title ~~[DO NOT MERGE] Adding SQL managedDatabases swagger for API v2018-06-01-preview~~ Adding SQL managedDatabases swagger for API v2018-06-01-preview Sep 16, 2019

michaeljqzq merged commit 317aaa0 into Azure:master Sep 18, 2019

AutorestCI mentioned this pull request Sep 18, 2019

[AutoPR sql/resource-manager] Adding SQL managedDatabases swagger for API v2018-06-01-preview Azure/azure-sdk-for-python#7329

Merged

misosic-msft mentioned this pull request Oct 3, 2019

Refreshing SQL ManagedDatabase SDK. Azure/azure-sdk-for-net#7808

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding SQL managedDatabases swagger for API v2018-06-01-preview #7172

Adding SQL managedDatabases swagger for API v2018-06-01-preview #7172

misosic-msft commented Sep 10, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 10, 2019 •

edited

Loading

AutorestCI commented Sep 10, 2019 •

edited

Loading

AutorestCI commented Sep 10, 2019 •

edited

Loading

azuresdkci commented Sep 10, 2019

misosic-msft commented Sep 11, 2019

michaeljqzq commented Sep 12, 2019

misosic-msft commented Sep 12, 2019

michaeljqzq commented Sep 16, 2019

misosic-msft commented Sep 16, 2019 •

edited

Loading

misosic-msft commented Sep 17, 2019

Adding SQL managedDatabases swagger for API v2018-06-01-preview #7172

Adding SQL managedDatabases swagger for API v2018-06-01-preview #7172

Conversation

misosic-msft commented Sep 10, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Sep 10, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 65fd128, Iteration 10)

AutorestCI commented Sep 10, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 10, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Sep 10, 2019

misosic-msft commented Sep 11, 2019

michaeljqzq commented Sep 12, 2019

misosic-msft commented Sep 12, 2019

michaeljqzq commented Sep 16, 2019

misosic-msft commented Sep 16, 2019 • edited Loading

misosic-msft commented Sep 17, 2019

misosic-msft commented Sep 10, 2019 •

edited

Loading

openapi-sdkautomation bot commented Sep 10, 2019 •

edited

Loading

AutorestCI commented Sep 10, 2019 •

edited

Loading

AutorestCI commented Sep 10, 2019 •

edited

Loading

misosic-msft commented Sep 16, 2019 •

edited

Loading