Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'unmaskedIpLoggingStatus' to IotSecuritySolution #7283

Merged
merged 4 commits into from
Nov 6, 2019
Merged

Add 'unmaskedIpLoggingStatus' to IotSecuritySolution #7283

merged 4 commits into from
Nov 6, 2019

Conversation

liranc
Copy link
Contributor

@liranc liranc commented Sep 22, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@liranc liranc added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 22, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 22, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from ce02bce, Iteration 2)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Sep 22, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 22, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8450

@AutorestCI AutorestCI mentioned this pull request Sep 22, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 22, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6275

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 22, 2019
Closed
@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 7, 2019
anuchandy
anuchandy approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from SDK side, feature development is complete, once arm approves, it will be deployed.

This was referenced Oct 7, 2019
Closed
Closed
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 7, 2019
Closed
@liranc liranc removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 28, 2019
@pilor pilor added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 28, 2019
@anuchandy anuchandy merged commit 6dc8c8d into Azure:master Nov 6, 2019
This was referenced Nov 6, 2019
Merged
Merged
@liranc liranc mentioned this pull request Nov 11, 2019
Merged
@liranc liranc deleted the liran-dev-security-Microsoft.Security-2019-08-01 branch January 1, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pilor pilor pilor approved these changes

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liranc @AutorestCI @azuresdkci @pilor @anuchandy