Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataFactory]Add Dynamics Server-toServer authentication type. #7437

Merged
merged 2 commits into from
Oct 17, 2019
Merged

[DataFactory]Add Dynamics Server-toServer authentication type. #7437

merged 2 commits into from
Oct 17, 2019

Conversation

sjtuxzq
Copy link
Contributor

@sjtuxzq sjtuxzq commented Oct 9, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 9, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 7face07, Iteration 3)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
Pending Go: test-repo-billy/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: test-repo-billy/azure-sdk-for-js
  • Package generation pending.

@azuresdkci azuresdkci requested a review from lirenhe October 9, 2019 07:55
@AutorestCI
Copy link

AutorestCI commented Oct 9, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7962

@AutorestCI
Copy link

AutorestCI commented Oct 9, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6068

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

This was referenced Oct 9, 2019
Closed
Closed
@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 10, 2019
KrisBash
KrisBash approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 16, 2019
@lirenhe lirenhe merged commit d6dc3f5 into Azure:master Oct 17, 2019
This was referenced Oct 17, 2019
Merged
Merged
@sjtuxzq sjtuxzq mentioned this pull request Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe approved these changes

@KrisBash KrisBash KrisBash approved these changes

Assignees

@lirenhe lirenhe

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sjtuxzq @AutorestCI @azuresdkci @KrisBash @lirenhe @zhenqxuMSFT