Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix swagger completeness issue #7752

Merged
merged 6 commits into from
Nov 14, 2019
Merged

fix swagger completeness issue #7752

merged 6 commits into from
Nov 14, 2019

Conversation

yibirnba
Copy link
Contributor

@yibirnba yibirnba commented Nov 10, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci azuresdkci requested a review from njuCZ November 10, 2019 11:22
@AutorestCI AutorestCI mentioned this pull request Nov 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8450

@AutorestCI AutorestCI mentioned this pull request Nov 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6331

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yibirnba
Copy link
Contributor Author

Hi, making sure it won't create a breaking change in clients (instead of one function, we now have 2)

@PhoenixHe-NV
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@PhoenixHe-NV
Copy link
Contributor

@yibirnba CI passes after rerun.

@njuCZ njuCZ added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 12, 2019
@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 13, 2019
@njuCZ njuCZ merged commit a84752d into Azure:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuCZ njuCZ njuCZ approved these changes

Assignees

@njuCZ njuCZ

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yibirnba @AutorestCI @azuresdkci @PhoenixHe-NV @njuCZ @ravbhatnagar