[SRP] Add new property EnabledProtocols for file shares #7815

zfchen95 · 2019-11-20T23:14:49Z

Approved in private branch. https://github.com/Azure/azure-rest-api-specs-pr/pull/859

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Approved in private branch.

AutorestCI · 2019-11-20T23:15:26Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6461

azuresdkci · 2019-11-20T23:15:28Z

Can one of the admins verify this patch?

AutorestCI · 2019-11-20T23:15:53Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8761

blueww · 2019-11-21T08:44:38Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json

+          },
+          "description": "Protocols for file shares"
+        },
+        "rootSquash": {


The enum name is same as one of it's value (both "RootSquash"). This will make the .NET SDK code generated from it build fail.

ryansbenson · 2019-11-21T19:41:17Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json

@@ -239,7 +242,7 @@
            "in": "body",
            "required": true,
            "schema": {
-              "$ref": "#/definitions/FileShare"
+              "$ref": "#/definitions/FileShareCreateParameters"


Why are you forking the body definition for create/put? With the readonly fields of FileShare, FileShareCreateParameters is effectively the same. Doing this will generate a 2 classes the user would interact with for no real reason.

EnabledProtocol is the property that can only be set at creation. We can stay with one body definition. But customer will be confused since enabledProtocol cannot be updated.

ryansbenson · 2019-11-21T19:45:11Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json

@@ -524,10 +544,107 @@
          "minimum": 1,
          "maximum": 5120,
          "description": "The maximum size of the share, in gigabytes. Must be greater than 0, and less than or equal to 5TB (5120)."
+        },
+        "enabledProtocols": {


Adding writable fields to a stable api version is seen as a breaking change and requires a new api version. See the section labeled 'New property added to response' in the following link. This was introduced long back to prevent breaking previous versions of the sdk.

https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Breaking%20changes%20guidelines.md#new-property-added-to-response

From the server side, if the new properties did not show up in the request, we will no wipe them out. We have a lot of experience in adding new properties to storage account in the existing API version. It (Get-Put model) is not a concern from my prospect..

…into nfsshare

blueww · 2019-11-25T05:51:43Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json

@@ -312,8 +315,7 @@
          "200": {
            "description": "OK -- Update Share operation completed successfully.",
            "schema": {
-              "$ref": "#/definitions/FileShare",
-              "description": "Properties of the updated file share."


We should not remove the description, or the doc/SDK generated from swagger will missing description for this property.
We can change it to make it more accurate.

blueww · 2019-11-27T03:13:53Z

The feature target public preview on 2020,Feb , so don't merge it now.

KrisBash

Signing off for ARM. Issues with enum name notwithstanding

…pecs into nfsshare

azure-pipelines · 2020-01-22T18:46:39Z

Comment was made before the most recent commit for PR 7815 in repo Azure/azure-rest-api-specs

Juliehzl · 2020-02-07T06:40:18Z

/azp run

azure-pipelines · 2020-02-07T06:40:37Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2020-02-07T06:41:49Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from c95b01e with merge commit e9bbf4159d9fd403464231eab2ac20299b853ef2. SDK Automation 13.0.17.20191226.1
⚠️preview/storage/mgmt/2015-05-01-preview [Logs]
```
No file is changed.
```
⚠️preview/storage/mgmt/2018-03-01-preview [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2015-06-15 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-01-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-05-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-12-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-06-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-07-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-11-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
️✔️storage/mgmt/2019-06-01 [Logs] [Preview SDK Changes]
- storage.mgmt.2019-06-01.zip

openapi-sdkautomation · 2020-02-07T06:41:50Z

azure-sdk-for-net

❌ failed [Logs] [Expand Details]

❌ Generate from c95b01e with merge commit e9bbf4159d9fd403464231eab2ac20299b853ef2. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

❌Microsoft.Azure.Management.Storage [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Storage.4.2.0-preview.nupkg
- Microsoft.Azure.Management.Storage.4.2.0-preview.symbols.nupkg
```
Failed to create the package Microsoft.Azure.Management.Storage.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=storage /v:n /p:SkipTests=true , {} 
```

openapi-sdkautomation · 2020-02-07T06:41:51Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from c95b01e with merge commit e9bbf4159d9fd403464231eab2ac20299b853ef2. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-storage [Logs] [Preview SDK Changes]

azure-arm-storage-13.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/storageManagementClient.js → ./dist/arm-storage.js...
[npmPack] created ./dist/arm-storage.js in 471ms

openapi-sdkautomation · 2020-02-07T06:41:58Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from c95b01e with merge commit e9bbf4159d9fd403464231eab2ac20299b853ef2. SDK Automation 13.0.17.20191226.1
️✔️sdk/storage/mgmt-v2016_01_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2017_10_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2018_02_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2018_03_01_preview [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2018_07_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2019_04_01 [Logs] [Preview SDK Changes]

⚠️sdk/storage/mgmt-v2019_06_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[68,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storage: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[68,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-02-07T06:42:04Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from c95b01e with merge commit e9bbf4159d9fd403464231eab2ac20299b853ef2. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-storage [Logs] [Preview SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-03-01-preview', '2018-07-01'} in label v2018_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

blueww · 2020-02-07T10:14:04Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json

+            "name": "EnabledProtocols",
+            "modelAsString": true
+          },
+          "description": "Immutable property for file shares protocol.",


Please add more description for what the value means. What's the effect when specify each of the 2 values. What's the default value.

blueww · 2020-02-07T10:14:45Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json

+            "name": "RootSquashType",
+            "modelAsString": true
+          },
+          "description": "Reduction of the access rights for the remote superuser."


Please add more description for What's the effect when specify each of the 3 values. What's the default value.

[SRP] Add new property EnabledProtocols for file shares

2887974

Approved in private branch.

azuresdkci assigned njuCZ Nov 20, 2019

azuresdkci requested a review from njuCZ November 20, 2019 23:15

Fix addtional properties issue

8627370

This was referenced Nov 21, 2019

[AutoPR storage/resource-manager] [SRP] Add new property EnabledProtocols for file shares Azure/azure-sdk-for-python#8760

Closed

[AutoPR storage/resource-manager] [SRP] Add new property EnabledProtocols for file shares Azure/azure-sdk-for-go#6399

Closed

Fixing...

f64f901

njuCZ added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 21, 2019

blueww reviewed Nov 21, 2019

View reviewed changes

ryansbenson reviewed Nov 21, 2019

View reviewed changes

ryansbenson added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 21, 2019

Remove create and update params

b442fad

zfchen95 requested a review from ryansbenson November 22, 2019 21:27

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

1cdc3aa

…into nfsshare

blueww reviewed Nov 25, 2019

View reviewed changes

zfchen95 added 2 commits November 25, 2019 19:27

Update file.json

06c3a7c

Update file.json

5676940

blueww added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 27, 2019

Update file.json

dbef20a

AutorestCI mentioned this pull request Dec 2, 2019

[AutoPR storage/resource-manager] [SRP] Add new property EnabledProtocols for file shares Azure/azure-sdk-for-go#6461

Closed

KrisBash approved these changes Dec 3, 2019

View reviewed changes

Juliehzl mentioned this pull request Jan 2, 2020

[Storage] Create and list support for NFS file shares Azure/azure-cli#11734

Closed

Merge branch 'master' of https://github.com/zfchen95/azure-rest-api-s…

c95b01e

…pecs into nfsshare

blueww reviewed Feb 7, 2020

View reviewed changes

zfchen95 mentioned this pull request Mar 31, 2020

SRP recent file share API change #8900

Merged

5 tasks

zfchen95 closed this Apr 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SRP] Add new property EnabledProtocols for file shares #7815

[SRP] Add new property EnabledProtocols for file shares #7815

zfchen95 commented Nov 20, 2019

AutorestCI commented Nov 20, 2019 •

edited

Loading

azuresdkci commented Nov 20, 2019

AutorestCI commented Nov 20, 2019 •

edited

Loading

blueww Nov 21, 2019

ryansbenson Nov 21, 2019

zfchen95 Nov 22, 2019

ryansbenson Nov 21, 2019

zfchen95 Nov 22, 2019

blueww Nov 25, 2019

blueww commented Nov 27, 2019

KrisBash left a comment

azure-pipelines bot commented Jan 22, 2020

Juliehzl commented Feb 7, 2020

azure-pipelines bot commented Feb 7, 2020

openapi-sdkautomation bot commented Feb 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 7, 2020 •

edited

Loading

blueww Feb 7, 2020

blueww Feb 7, 2020

[SRP] Add new property EnabledProtocols for file shares #7815

[SRP] Add new property EnabledProtocols for file shares #7815

Conversation

zfchen95 commented Nov 20, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Nov 20, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Nov 20, 2019

AutorestCI commented Nov 20, 2019 • edited Loading

Automation for azure-sdk-for-python

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blueww commented Nov 27, 2019

KrisBash left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Jan 22, 2020

Juliehzl commented Feb 7, 2020

azure-pipelines bot commented Feb 7, 2020

openapi-sdkautomation bot commented Feb 7, 2020 • edited Loading

azure-sdk-for-go

openapi-sdkautomation bot commented Feb 7, 2020 • edited Loading

azure-sdk-for-net

openapi-sdkautomation bot commented Feb 7, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Feb 7, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Feb 7, 2020 • edited Loading

azure-sdk-for-python

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented Nov 20, 2019 •

edited

Loading

AutorestCI commented Nov 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Feb 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 7, 2020 •

edited

Loading