Updating Functions ARM APIs #7939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
This was referenced Dec 10, 2019
Closed
Closed
yungezz
reviewed
Dec 11, 2019
| @@ -3323,14 +3323,14 @@ | |||
| } | |||
| } | |||
| }, | |||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/functions/{functionName}/listsecrets": { | |||
| "post": { | |||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/functions/{functionName}/keys/{keyName}": { | |||
There was a problem hiding this comment.
since this is stable version, change on path of stable version is treated as breaking change, because user is using it. suggest to make the change in new version
There was a problem hiding this comment.
This is just a diff/whitespace issue. If you look at this in windiff for example you'll see no existing routes were changed. Not sure why the diff mangles things so.
| "summary": "Get function secrets for a function in a web site, or a deployment slot.", | ||
| "description": "Description for Get function secrets for a function in a web site, or a deployment slot.", | ||
| "operationId": "WebApps_ListFunctionSecrets", | ||
| "summary": "Add or update a function secret.", |
There was a problem hiding this comment.
if path name changed secret to key, description,. operationId should be changed also for consistent.
There was a problem hiding this comment.
No existing paths or routes were changed in this PR. Just additions. Please see above.
yungezz
added
the
WaitForARMFeedback
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mathewc
force-pushed
the
functions-spec-updates
branch
from
595d452 to
022b652
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
yungezz
added
potential-sdk-breaking-change
and removed
WaitForARMFeedback
yungezz
approved these changes
Dec 12, 2019
mathewc
force-pushed
the
functions-spec-updates
branch
from
022b652 to
5325b29
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
yungezz
approved these changes
Dec 13, 2019
|
looking at LintDiff error with @mathewc |
|
@yungezz, I don’t understand these failures. The spec changes I’m making here were already accepted and checked in previously. The Lint error in question appears to be from the definition of the KeyInfo type and the fact that it isn’t a ProxyOnlyResource. As you can see from the previous stable version here, the definition is the same. These APIs/definitions were already merged previously by you guys in that 2018-02-01 stable version. Now I could just go in and make this spec definition inherit ProxyOnlyResource properties to make the Lint tool happy, but that would be incorrect – those properties are never accepted/returned from the APIs using this type. I think we need to get this in as is – please tell me how to proceed. "KeyInfo": {
"description": "Function key info.",
"type": "object",
"properties": {
"name": {
"description": "Key name",
"type": "string"
},
"value": {
"description": "Key value",
"type": "string"
}
}
} |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mathewc
force-pushed
the
functions-spec-updates
branch
from
5325b29 to
5c8ca13
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
mathewc
force-pushed
the
functions-spec-updates
branch
from
5c8ca13 to
045586b
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
mathewc
force-pushed
the
functions-spec-updates
branch
from
045586b to
e69efc9
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
mathewc
force-pushed
the
functions-spec-updates
branch
from
e69efc9 to
cf9aefe
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
mathewc
force-pushed
the
functions-spec-updates
branch
from
cf9aefe to
b509f75
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Lint errors fixed @yungezz |
yungezz
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the changes made in #7174 to the latest spec version. No service changes have been made - just pulling these previously reviewed specs forward. No backend RP changes were made - this just updates the spec to be inline with what is already there.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.