Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Stack] Update fabric storage admin specs for new generation with autorest-beta #8038

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

zyxyoshine
Copy link
Contributor

  1. Update package version to 2019-05-01
  2. Add Top/Skip parameters for List

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@zyxyoshine
Copy link
Contributor Author

@bganapa , this is to make generated module support Top/Skip params to align with previous Admin PowerShell module and update the package version to the latest. Please help review.

@zyxyoshine
Copy link
Contributor Author

@bganapa could you help review this PR? Thanks.

@bganapa bganapa merged commit 6ecda64 into Azure:stackadmin Jan 3, 2020
viananth added a commit to viananth/azure-rest-api-specs that referenced this pull request Mar 26, 2020
commit 6ecda64
Author: Yuxing Zhou <zyx.pulsars@gmail.com>
Date:   Sat Jan 4 02:25:35 2020 +0800

    [Azure Stack] Update fabric storage admin specs for new generation with autorest-beta (Azure#8038)
    commit 9e551f0                                                                         Author: bganapa <bganapa@microsoft.com>                                                     Date:   Tue Nov 12 11:44:22 2019 -0800                                         Reset to Stackadmin2 (Azure#7766)
akning-ms pushed a commit that referenced this pull request Sep 4, 2020
…9030)

* Cumulative commit message:
commit 6ecda64
Author: Yuxing Zhou <zyx.pulsars@gmail.com>
Date:   Sat Jan 4 02:25:35 2020 +0800

    [Azure Stack] Update fabric storage admin specs for new generation with autorest-beta (#8038)
    commit 9e551f0                                                                         Author: bganapa <bganapa@microsoft.com>                                                     Date:   Tue Nov 12 11:44:22 2019 -0800                                         Reset to Stackadmin2 (#7766)

* Address PR comments

* Fix semantic issue

* Reset NasCluster files to master

* Add nascluster changes

* Revert readme.md changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants