Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added monitor subnet to SapMonitor model #8915

Merged
merged 4 commits into from
Apr 9, 2020
Merged

Added monitor subnet to SapMonitor model #8915

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5be6a58
Added monitor subnet to SapMonitor model
PakDLiu Apr 1, 2020
196970a
updated examples
PakDLiu Apr 2, 2020
8eb4ad1
Fixed JSON
PakDLiu Apr 3, 2020
ff1fa6d
fixed examples
PakDLiu Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/SapMonitors_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"enableCustomerAnalytics": true,
"logAnalyticsWorkspaceArmId": "",
"logAnalyticsWorkspaceId": "",
"logAnalyticsWorkspaceSharedKey": ""
"logAnalyticsWorkspaceSharedKey": "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"" [](start = 42, length = 2)

Can you provide example resource IDs for all the properties that are being specified. "" is not really helpful to users. (This comment applies to all examples and properties in the examples.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"monitorSubnet": ""
}
}
},
Expand All @@ -35,6 +36,7 @@
"logAnalyticsWorkspaceArmId": "",
"logAnalyticsWorkspaceId": "",
"logAnalyticsWorkspaceSharedKey": "",
"monitorSubnet": "",
"managedResourceGroupName": "",
"sapMonitorCollectorVersion": "",
"provisioningState": "Succeeded"
Expand All @@ -55,6 +57,7 @@
"logAnalyticsWorkspaceArmId": "",
"logAnalyticsWorkspaceId": "",
"logAnalyticsWorkspaceSharedKey": "",
"monitorSubnet": "",
"managedResourceGroupName": "",
"sapMonitorCollectorVersion": "",
"provisioningState": "Accepted"
Expand Down
1 change: 1 addition & 0 deletions ...ce-manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/SapMonitors_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"logAnalyticsWorkspaceArmId": "",
"logAnalyticsWorkspaceId": "",
"logAnalyticsWorkspaceSharedKey": "",
"monitorSubnet": "",
"managedResourceGroupName": "",
"sapMonitorCollectorVersion": "",
"provisioningState": "Succeeded"
Expand Down
2 changes: 2 additions & 0 deletions ...e-manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/SapMonitors_List.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"logAnalyticsWorkspaceArmId": "",
"logAnalyticsWorkspaceId": "",
"logAnalyticsWorkspaceSharedKey": "",
"monitorSubnet": "",
"managedResourceGroupName": "",
"sapMonitorCollectorVersion": "",
"provisioningState": "Succeeded"
Expand All @@ -38,6 +39,7 @@
"logAnalyticsWorkspaceArmId": "",
"logAnalyticsWorkspaceId": "",
"logAnalyticsWorkspaceSharedKey": "",
"monitorSubnet": "",
"managedResourceGroupName": "",
"sapMonitorCollectorVersion": "",
"provisioningState": "Succeeded"
Expand Down
1 change: 1 addition & 0 deletions ...ager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/SapMonitors_PatchTags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"logAnalyticsWorkspaceArmId": "",
"logAnalyticsWorkspaceId": "",
"logAnalyticsWorkspaceSharedKey": "",
"monitorSubnet": "",
"managedResourceGroupName": "",
"sapMonitorCollectorVersion": "",
"provisioningState": "Succeeded"
Expand Down
1 change: 1 addition & 0 deletions ...crosoft.HanaOnAzure/preview/2020-02-07-preview/examples/SapMonitors_PatchTags_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"logAnalyticsWorkspaceArmId": "",
"logAnalyticsWorkspaceId": "",
"logAnalyticsWorkspaceSharedKey": "",
"monitorSubnet": "",
"managedResourceGroupName": "",
"sapMonitorCollectorVersion": "",
"provisioningState": "Succeeded"
Expand Down
4 changes: 4 additions & 0 deletions ...nazure/resource-manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/hanaonazure.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,10 @@
"readOnly": true,
"type": "string",
"description": "The version of the payload running in the Collector VM"
},
"monitorSubnet": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monitorSubnet [](start = 9, length = 13)

Is this property required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this is a breaking change that should be done in a new API version.

In reply to: 402059679 [](ancestors = 402059679)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a preview API version and the API is still in flux.
We also know that no one outside of our team is using this API yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. That's fine then.

In general, I would recommend working in a development branch in the public or private Swagger repo when the API is still in flux. What's in master branch in this repo is considered public and available for use regardless of the -preview suffix on the API version.

In reply to: 402062621 [](ancestors = 402062621)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!
Will do that in the future

"type": "string",
"description": "The subnet which the SAP monitor will be deployed in"
}
},
"description": "Describes the properties of a SAP monitor."
Expand Down