Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing one nat rule restriction in a nat rule collection - Firewall Policy[DO NOT MERGE] #9246

Closed
wants to merge 1 commit into from
Closed

Removing one nat rule restriction in a nat rule collection - Firewall Policy[DO NOT MERGE] #9246

wants to merge 1 commit into from

Conversation

saisujithreddym
Copy link
Contributor

@saisujithreddym saisujithreddym commented Apr 27, 2020 •
edited by lirenhe
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saisujithreddym saisujithreddym changed the title Removing one nat rule restriction in a nat rule collection Removing one nat rule restriction in a nat rule collection - Firewall Policy Apr 27, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 27, 2020 •
edited
Loading

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 50bd5a5 with merge commit eb69745ce76773f543d00471fe0c1b865b1afb1f. SDK Automation 13.0.17.20200424.4
  • ⚠️network/mgmt/2015-06-15 [Logs]  
      No file is changed.
    • ⚠️network/mgmt/2016-03-30 [Logs]  
        No file is changed.
      • ⚠️network/mgmt/2016-06-01 [Logs]  
          No file is changed.
        • ⚠️network/mgmt/2016-09-01 [Logs]  
            No file is changed.
          • ⚠️network/mgmt/2016-12-01 [Logs]  
              No file is changed.
            • ⚠️network/mgmt/2017-03-01 [Logs]  
                No file is changed.
              • ⚠️network/mgmt/2017-06-01 [Logs]  
                  No file is changed.
                • ⚠️network/mgmt/2017-08-01 [Logs]  
                    No file is changed.
                  • ⚠️network/mgmt/2017-09-01 [Logs]  
                      No file is changed.
                    • ⚠️network/mgmt/2017-10-01 [Logs]  
                        No file is changed.
                      • ⚠️network/mgmt/2017-11-01 [Logs]  
                          No file is changed.
                        • ⚠️network/mgmt/2018-01-01 [Logs]  
                            No file is changed.
                          • ⚠️network/mgmt/2018-02-01 [Logs]  
                              No file is changed.
                            • ⚠️network/mgmt/2018-04-01 [Logs]  
                                No file is changed.
                              • ⚠️network/mgmt/2018-06-01 [Logs]  
                                  No file is changed.
                                • ⚠️network/mgmt/2018-07-01 [Logs]  
                                    No file is changed.
                                  • ⚠️network/mgmt/2018-08-01 [Logs]  
                                      No file is changed.
                                    • ⚠️network/mgmt/2018-10-01 [Logs]  
                                        No file is changed.
                                      • ⚠️network/mgmt/2018-11-01 [Logs]  
                                          No file is changed.
                                        • ⚠️network/mgmt/2018-12-01 [Logs]  
                                            No file is changed.
                                          • ⚠️network/mgmt/2019-02-01 [Logs]  
                                              No file is changed.
                                            • ⚠️network/mgmt/2019-04-01 [Logs]  
                                                No file is changed.
                                              • ⚠️network/mgmt/2019-06-01 [Logs]  
                                                  No file is changed.
                                                • ⚠️network/mgmt/2019-07-01 [Logs]  
                                                    No file is changed.
                                                  • ⚠️network/mgmt/2019-08-01 [Logs]  
                                                      No file is changed.
                                                    • ⚠️network/mgmt/2019-09-01 [Logs]  
                                                        No file is changed.
                                                      • ⚠️network/mgmt/2019-11-01 [Logs]  
                                                          No file is changed.
                                                        • ⚠️network/mgmt/2019-12-01 [Logs]  
                                                            No file is changed.
                                                          • ⚠️preview/network/mgmt/2015-05-01-preview [Logs]  
                                                              No file is changed.

                                                            @openapi-sdkautomation
                                                            Copy link

                                                            openapi-sdkautomation bot commented Apr 27, 2020 •
                                                            edited
                                                            Loading

                                                            azure-sdk-for-net

                                                            🔄 inProgress [Logs] [Expand Details]
                                                            • 🔄 Generate from 50bd5a5 with merge commit eb69745ce76773f543d00471fe0c1b865b1afb1f. SDK Automation 13.0.17.20200424.4

                                                            @openapi-sdkautomation
                                                            Copy link

                                                            openapi-sdkautomation bot commented Apr 27, 2020 •
                                                            edited
                                                            Loading

                                                            azure-cli-extensions

                                                            No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

                                                            @openapi-sdkautomation
                                                            Copy link

                                                            openapi-sdkautomation bot commented Apr 27, 2020 •
                                                            edited
                                                            Loading

                                                            azure-sdk-for-java

                                                            ⚠️ warning [Logs] [Expand Details]
                                                            • ⚠️ Generate from 50bd5a5 with merge commit eb69745ce76773f543d00471fe0c1b865b1afb1f. SDK Automation 13.0.17.20200424.4
                                                            • ⚠️sdk/network/mgmt-v2019_02_01 [Logs]  
                                                                No file is changed.
                                                              • ⚠️sdk/network/mgmt-v2019_04_01 [Logs]  
                                                                  No file is changed.
                                                                • ⚠️sdk/network/mgmt-v2019_06_01 [Logs]  
                                                                    No file is changed.
                                                                  • ⚠️sdk/network/mgmt-v2019_07_01 [Logs]  
                                                                      No file is changed.
                                                                    • ⚠️sdk/network/mgmt-v2019_08_01 [Logs]  
                                                                        No file is changed.
                                                                      • ⚠️sdk/network/mgmt-v2019_09_01 [Logs]  
                                                                          No file is changed.

                                                                        @openapi-sdkautomation
                                                                        Copy link

                                                                        openapi-sdkautomation bot commented Apr 27, 2020 •
                                                                        edited
                                                                        Loading

                                                                        azure-sdk-for-js

                                                                        ️✔️ succeeded [Logs] [Expand Details]

                                                                        @openapi-sdkautomation
                                                                        Copy link

                                                                        openapi-sdkautomation bot commented Apr 27, 2020 •
                                                                        edited
                                                                        Loading

                                                                        azure-sdk-for-python

                                                                        ⚠️ warning [Logs] [Expand Details]
                                                                        • ⚠️ Generate from 50bd5a5 with merge commit eb69745ce76773f543d00471fe0c1b865b1afb1f. SDK Automation 13.0.17.20200424.4 
                                                                          Failed to find any diff after autorest so no changed packages was found.

                                                                        @azuresdkci
                                                                        Copy link
                                                                        Contributor

                                                                        Can one of the admins verify this patch?

                                                                        @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Apr 27, 2020
                                                                        Open
                                                                        @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 28, 2020
                                                                        @saisujithreddym saisujithreddym changed the title Removing one nat rule restriction in a nat rule collection - Firewall Policy Removing one nat rule restriction in a nat rule collection - Firewall Policy[DO NOT MERGE] Apr 29, 2020
                                                                        @anton-evseev anton-evseev added the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 4, 2020
                                                                        @saisujithreddym
                                                                        Copy link
                                                                        Contributor Author

                                                                        I will make this PR against the may release branch. Closing this for now

                                                                        @saisujithreddym saisujithreddym mentioned this pull request May 7, 2020
                                                                        Merged
                                                                        5 tasks
                                                                        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                                                                        Reviewers

                                                                        @lirenhe lirenhe lirenhe approved these changes

                                                                        @MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

                                                                        @anton-evseev anton-evseev Awaiting requested review from anton-evseev

                                                                        @v-shhatt v-shhatt Awaiting requested review from v-shhatt

                                                                        Assignees

                                                                        @lirenhe lirenhe

                                                                        Labels
                                                                        DoNotMerge <valid label in PR review process> use to hold merge after approval WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
                                                                        Projects
                                                                        None yet
                                                                        Milestone
                                                                        No milestone
                                                                        Development

                                                                        Successfully merging this pull request may close these issues.
                                                                        4 participants
                                                                        @saisujithreddym @azuresdkci @lirenhe @anton-evseev