-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anf 567 anf swagger restapi to2020 02 01 no snapshotpolicy #9742
Anf 567 anf swagger restapi to2020 02 01 no snapshotpolicy #9742
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
Can one of the admins verify this patch? |
Can we get this looked at please? |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Can we please get this moving urgently needed changes with customers waiting |
Can we get this merged? |
Can this be merged urgently needed by customers |
@zikalino @chiragg4u Can we get this merged? |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -111,7 +120,6 @@ swagger-to-sdk: | |||
- repo: azure-sdk-for-js | |||
- repo: azure-sdk-for-go | |||
- repo: azure-sdk-for-java | |||
- repo: azure-sdk-for-trenton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we know why remove this entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I missed that entry, I am not sure what it is can I ask what is it for?
Let me know if it is needed and I will add it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need TerraForm? it yes. you need add it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I added it back.
output-folder: $(azure-libraries-for-java-folder)/sdk/netapp/mgmt-v2020_02_01 | ||
regenerate-manager: true | ||
generate-interface: true | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weidongxu-microsoft to take a look this change for Java SDK impact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It is same as the last one ### Tag: package-netapp-2019-11-01 and java
, with change on version. So generally it is good.
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
* Initial commit from previous API version * updated to 2020-02-01 * update snapshot example * Validation issues fixes * Fix missing example volumeReplicationStatusGet * Fix missing result example Account Update * Fix missing Account Update op * Fix missing Account Update result code * Fix missing Account Update syntax * Fix underscore * Fix example * Fix Readme * Updated API version in examples * ran prettier * Prettier examples * Trigger automation pipeline * Rervert volue replicationStatus methods change * Rervert volue replicationStatus methods change * prettier * Added Repo Azure sdk for trenton again * Added trenton metadata Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.