-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vcpkg baseline to the October 2022 tag. #2400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd get ok from the IoT team, and also let's update the C++ repo to the same tag/commit SHA.
Looks like all the linux legs are failing (but only the linux ones) because the vcpkg version installed is different than the ones we need. I am wondering if it is a vcpkg caching issue, or possibly the vcpkg version pre-installed on the linux machines are out-dated and need to be fixed.
|
As long as the E2E tests pass and it compiles looks okay to me. |
@ahsonkhan I'm not an expert but based on the issue microsoft/vcpkg#23748 it looks like it might have to do something with the builtin-baseline sha. |
This probably means you're missing a fetch? microsoft/vcpkg@94ce0da exists. |
@BillyONeal, I can try adding a Basically, where is this commit, |
I'm not sure, is this actually a clone? Unfortunately I don't know about how you invoke us and it isn't obvious from this change. Doing a I do observe that the commit you're explicitly trying to checkout is older than the baseline you're trying to use, so there may be versions referenced by that baseline that are unreachable by the version database in use? |
Really? |
/azp run c - client - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run c - client - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Based on recommendation from Billy, we decided to avoid using |
Thank you @ahsonkhan! Can you please make a PR to update the C++ repo to the same commit SHA? |
Done in Azure/azure-sdk-for-cpp#4100 |
No description provided.