Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vcpkg manifests: re-add version constraints #2735

Closed
antkmsft opened this issue Aug 11, 2021 · 1 comment · Fixed by #2781
Closed

Vcpkg manifests: re-add version constraints #2735

antkmsft opened this issue Aug 11, 2021 · 1 comment · Fixed by #2781
Assignees
@antkmsft
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Milestone
[2021] September

Comments

@antkmsft
Copy link
Member

antkmsft commented Aug 11, 2021 •
edited
Loading

Re-add builtin-baseline and version>=.

We had to remove them because vcpkg found a bug in that functionality, so they had to remove them from our manifests (microsoft/vcpkg#19299) until the proper fix is in place - microsoft/vcpkg-tool#151 (plus, confirm with Robert Schumacher that we are good to go).
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 11, 2021
@antkmsft antkmsft mentioned this issue Aug 11, 2021
Merged
@RickWinter RickWinter added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Aug 11, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 11, 2021
@RickWinter RickWinter added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Aug 11, 2021
@RickWinter RickWinter added this to the [2022] January milestone Aug 11, 2021
@ras0219-msft
Copy link

Note that in addition to waiting for microsoft/vcpkg-tool#151 to merge the new tool version needs to roll out (typically 1-2 weeks unless a critical issue forces an earlier deployment).

@antkmsft antkmsft mentioned this issue Aug 12, 2021
Merged
14 tasks
@antkmsft antkmsft mentioned this issue Aug 23, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@antkmsft antkmsft

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
[2021] September
Development

Successfully merging a pull request may close this issue.

Re-add vcpkg version constraints
3 participants
@RickWinter @ras0219-msft @antkmsft