Fix versioning features of transitive manifests #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two outstanding bugs with using versioning features in transitive manifests:
builtin-baseline
as part of transitive manifests if they provideversion>=
. This was a bug; we only needbuiltin-baseline
for the top-level manifest because it is a non-transitive property.Example setup:
ports/overlay/vcpkg.json
ports/overlay-zlib/vcpkg.json
Example error 1:
Example error 2 (after fixing the missing baseline):
The above example happens whenever the
version>=
disagrees with the current ports tree version.Expected output: