Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the TESTING_BUILD macro to make it clear it doesn't collide with a customer macro. #5334

Closed
ahsonkhan opened this issue Feb 9, 2024 · 0 comments · Fixed by #5390
Closed

Change the TESTING_BUILD macro to make it clear it doesn't collide with a customer macro. #5334

ahsonkhan opened this issue Feb 9, 2024 · 0 comments · Fixed by #5390
Assignees
@ahsonkhan
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. feature-request This issue requires a new behavior in the product in order be resolved. test-enhancement
Milestone
2024-03

Comments

@ahsonkhan
Copy link
Contributor

Proposal is to rename the TESTING_BUILD compiler definition to _azure_TESTING_BUILD and use that repo-wide, so that it is unique to the C++ Azure SDK.
@ahsonkhan ahsonkhan mentioned this issue Feb 9, 2024
Merged
@RickWinter RickWinter added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. blocking-release Blocks release feature-request This issue requires a new behavior in the product in order be resolved. and removed bug This issue requires a change to an existing behavior in the product in order to be resolved. labels Feb 9, 2024
@ahsonkhan ahsonkhan mentioned this issue Feb 9, 2024
Closed
This was referenced Feb 26, 2024
Closed
Merged
@ahsonkhan ahsonkhan added this to the 2024-03 milestone Mar 1, 2024
@ahsonkhan ahsonkhan mentioned this issue Mar 8, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ahsonkhan ahsonkhan

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. feature-request This issue requires a new behavior in the product in order be resolved. test-enhancement
Projects
None yet
Milestone
2024-03
2 participants
@RickWinter @ahsonkhan