For existing surface area, classes marked as final should not have virtual methods. #5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsonkhan
requested review from
antkmsft,
schaabs,
RickWinter,
vhvb1989,
gearama,
LarryOsterman and
a team
as code owners
ahsonkhan
requested review from
maorleger,
pvaneck,
billwert,
KarishmaGhiya,
chlowell and
mpodwysocki
antkmsft
previously requested changes
Feb 8, 2024
There was a problem hiding this comment.
Preprocessor-conditional virtual could be a source of hidden and strange bugs, I explained more here: #5331 (comment)
ahsonkhan
commented
Feb 9, 2024
Comment on lines
-34
to
-36
| #else | ||
| protected: | ||
| #endif |
There was a problem hiding this comment.
@LarryOsterman A good thing from this effort is we caught this protected: keyword with side effects, which was making unrelated structs like CacheKey etc. below protected, instead of private.
We can fix that now.
|
Since this PR impacts existing, already GA'd, bits, I am going to turn it into a draft PR for now and fix it up in the next release with the rest of the codebase, including core (as part of #5334). |
|
Superseded by #5389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5253 for existing identity surface.
For other parts of the repo (like in core/etc.), will follow-up separately and might consider a macro approach to make these ifdefs a little cleaner (an exception to the guideline to avoid using macros)