Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Azure.Core changelog to be more consise and complete for the beta.8 #2069

Merged
merged 5 commits into from
Apr 7, 2021
Merged

Update the Azure.Core changelog to be more consise and complete for the beta.8 #2069

merged 5 commits into from
Apr 7, 2021

Conversation

ahsonkhan
Copy link
Member

No description provided.

@ahsonkhan ahsonkhan added this to the [2021] April milestone Apr 7, 2021
@ahsonkhan ahsonkhan self-assigned this Apr 7, 2021
@ahsonkhan
Copy link
Member Author

Reviewing the commits since the last release: a864982...fb000d5

@ahsonkhan
Copy link
Member Author

@antkmsft want to add ADFS as a new future in identity?
#1947 (comment)

@ahsonkhan
Copy link
Member Author

@vhvb1989 , we should add this to new feature section since it is meaningful to the customer, agreed?
#2026

Also, we need a bug fix section for #1500 once it is ready to ship.

@ahsonkhan ahsonkhan mentioned this pull request Apr 7, 2021
Merged
@vhvb1989
Copy link
Member

vhvb1989 commented Apr 7, 2021

@vhvb1989 , we should add this to new feature section since it is meaningful to the customer, agreed?
#2026

Also, we need a bug fix section for #1500 once it is ready to ship.

I didn´t add it because it is expected to be transparent for end-users. I must admit that, whit the time, and each release, I am caring less and less abut the changelog. For many reasons, I think it's currently giving us more issues than benefits. So, I am happy with anything in it or not in it :)

@ahsonkhan ahsonkhan mentioned this pull request Apr 7, 2021
Merged
@ahsonkhan ahsonkhan requested a review from schaabs as a code owner April 7, 2021 21:33
ahsonkhan
ahsonkhan commented Apr 7, 2021
View reviewed changes
sdk/identity/azure-identity/CHANGELOG.md
@@ -2,6 +2,10 @@

## 1.0.0-beta.5 (2021-04-07)

### New Features

- Add Active Directory Federation Service (ADFS) support to `ClientSecretCredential`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antkmsft can you take another look at this PR, specifically identity CL changes?

@vhvb1989
Copy link
Member

vhvb1989 commented Apr 7, 2021

/check-enforcer override

@vhvb1989
Copy link
Member

vhvb1989 commented Apr 7, 2021

/check-enforcer override

@vhvb1989 vhvb1989 merged commit 46c84e3 into Azure:master Apr 7, 2021
@ahsonkhan ahsonkhan deleted the UpdateCL branch April 7, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antkmsft antkmsft antkmsft approved these changes

@vhvb1989 vhvb1989 vhvb1989 approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter

@schaabs schaabs Awaiting requested review from schaabs

Assignees

@ahsonkhan ahsonkhan

Labels
Azure.Core Docs
Projects
None yet
Milestone
[2021] April
Development

Successfully merging this pull request may close these issues.
3 participants
@ahsonkhan @vhvb1989 @antkmsft