Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for Storage Blob Service, Nullable, signed int, and others #213

Merged
merged 10 commits into from
Jun 30, 2020
Merged

Documentation for Storage Blob Service, Nullable, signed int, and others #213

merged 10 commits into from
Jun 30, 2020

Conversation

Jinming-Hu
Copy link
Member

No description provided.

@Jinming-Hu Jinming-Hu added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) blocking-release Blocks release labels Jun 24, 2020
@Jinming-Hu Jinming-Hu marked this pull request as draft June 24, 2020 08:49
@Jinming-Hu Jinming-Hu force-pushed the pr1 branch 2 times, most recently from 4a476d7 to 7aac834 Compare June 29, 2020 07:44
@Jinming-Hu Jinming-Hu changed the title Documentation for Storage Blob Service Documentation for Storage Blob Service, Nullable, signed int, and others Jun 29, 2020
@Jinming-Hu Jinming-Hu force-pushed the pr1 branch 2 times, most recently from 721f1f7 to 5b37e89 Compare June 29, 2020 07:54
@Jinming-Hu Jinming-Hu marked this pull request as ready for review June 29, 2020 08:04
@Jinming-Hu Jinming-Hu requested a review from RickWinter as a code owner June 29, 2020 08:04
@Jinming-Hu Jinming-Hu marked this pull request as draft June 30, 2020 01:02
@Jinming-Hu Jinming-Hu force-pushed the pr1 branch 2 times, most recently from abb4b0d to 7a4b590 Compare June 30, 2020 03:00
@Jinming-Hu Jinming-Hu marked this pull request as ready for review June 30, 2020 03:00
katmsft
katmsft approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@katmsft katmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pending issue needs to be discussed with the design guidelines team. Other parts look good to be merged.

@Jinming-Hu Jinming-Hu mentioned this pull request Jun 30, 2020
Closed
@vinjiang vinjiang merged commit 74ce806 into Azure:master Jun 30, 2020
@Jinming-Hu Jinming-Hu mentioned this pull request Jun 30, 2020
Closed
@Jinming-Hu Jinming-Hu deleted the pr1 branch June 30, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katmsft katmsft katmsft approved these changes

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan

@antkmsft antkmsft Awaiting requested review from antkmsft

@gilbertw gilbertw Awaiting requested review from gilbertw

@JeffreyRichter JeffreyRichter Awaiting requested review from JeffreyRichter

@vhvb1989 vhvb1989 Awaiting requested review from vhvb1989

@vinjiang vinjiang Awaiting requested review from vinjiang

@RickWinter RickWinter Awaiting requested review from RickWinter

Assignees
No one assigned
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jinming-Hu @katmsft @vinjiang