Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable profiling in perf piplines. #4398

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Enable profiling in perf piplines. #4398

merged 3 commits into from
Mar 8, 2023

Conversation

gearama
Copy link
Member

@gearama gearama commented Mar 1, 2023

To enable profiling , along with chnges in the automation the changes to the pipelines are required

  1. Installl valgrind -- profiling tool for linux and cpp
  2. add option to run profiling,
  3. pass it to automation

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

@gearama gearama changed the title profiling Enable profiling in perf piplines. Mar 1, 2023
@gearama
Copy link
Member Author

gearama commented Mar 1, 2023

ignore cspell when reviewing for the moment, Daniel is looking into why it failed, as there are no real failures, it seems to have grabbed the wrong version of cspell for some reason

@ahsonkhan
Copy link
Member

ignore cspell when reviewing for the moment, Daniel is looking into why it failed, as there are no real failures, it seems to have grabbed the wrong version of cspell for some reason

I am fixing that in #4393 but am hitting another infra issue, there:
#4397

Copy link
Member

@LarryOsterman LarryOsterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@danieljurek
Copy link
Member

The spell checker issue is fixed. Rebase this PR to get a more successful run of the spell checker.

Co-authored-by: Mike Harder <mharder@microsoft.com>
@gearama
Copy link
Member Author

gearama commented Mar 8, 2023

/azp run cpp - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gearama gearama merged commit 5e91f55 into Azure:main Mar 8, 2023
antkmsft pushed a commit that referenced this pull request Apr 5, 2023
* profiling

* dsadsada

* Update eng/pipelines/templates/jobs/perf.yml

Co-authored-by: Mike Harder <mharder@microsoft.com>

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
# Conflicts:
#	sdk/keyvault/azure-security-keyvault-certificates/perf.yml
#	sdk/keyvault/azure-security-keyvault-keys/perf.yml
#	sdk/keyvault/azure-security-keyvault-secrets/perf.yml
antkmsft pushed a commit that referenced this pull request Apr 5, 2023
* profiling

* dsadsada

* Update eng/pipelines/templates/jobs/perf.yml

Co-authored-by: Mike Harder <mharder@microsoft.com>

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
@gearama gearama deleted the valgrind branch January 16, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants