correct command for using specified openssl with cmake #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @ByteYue! We will review the pull request and get back to you soon. |
LarryOsterman
approved these changes
May 15, 2024
|
Thank you very much for catching my typo, the change looks good. Let me know if you're done with verifying the fixes so I can merge the changes in. |
ahsonkhan
reviewed
May 15, 2024
ahsonkhan
approved these changes
May 15, 2024
antkmsft
approved these changes
May 16, 2024
Hi @LarryOsterman , sorry for my late response. I have already passed the verification, everything is fine now, and it’s ready to be merged. |
azure-sdk
added a commit
to azure-sdk/vcpkg
that referenced
this pull request
Jul 12, 2024
## 1.13.0 (2024-07-12) ### Bugs Fixed - [[microsoft#5589]](Azure/azure-sdk-for-cpp#5589) Fix possible endless loop while polling curl socket. (A community contribution, courtesy of _[CurtizJ](https://github.com/CurtizJ)_) ### Other Changes - Updated JSON library to 3.11.3. - [[microsoft#5622]](Azure/azure-sdk-for-cpp#5622) Documentation fix for building the SDK with specific OpenSSL version. (A community contribution, courtesy of _[ByteYue](https://github.com/ByteYue)_) ### Acknowledgments Thank you to our developer community members who helped to make Azure Core better with their contributions to this release: - Anton Popov _([GitHub](https://github.com/CurtizJ))_ - AlexYue _([GitHub](https://github.com/ByteYue))_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Hi there, I'm trying to integrate the Azure SDK into apache doris, and during the process, I found that I need to specify a particular version of OpenSSL. At this point, I discovered that the related commands in the documentation were incorrect, so I'm attempting to correct the documentation through this PR.
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.