Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apiview] adding pr support #5932

Merged
merged 83 commits into from
Oct 4, 2024
Merged

[apiview] adding pr support #5932

merged 83 commits into from
Oct 4, 2024

Conversation

ckairen
Copy link
Member

@ckairen ckairen commented Aug 21, 2024 •
edited
Loading

@ckairen ckairen added the Central-EngSys This issue is owned by the Engineering System team. label Aug 21, 2024
@ckairen ckairen self-assigned this Aug 21, 2024
@ckairen ckairen marked this pull request as ready for review August 22, 2024 16:42
@praveenkuttappan
Copy link
Member

/azp run cpp - template - ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ckairen
Copy link
Member Author

ckairen commented Aug 29, 2024

/azp run cpp - template - ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

praveenkuttappan
praveenkuttappan approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@praveenkuttappan praveenkuttappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, Otherwise it looks fine. Please remove test line added in template package.

@ckairen ckairen enabled auto-merge (squash) September 30, 2024 17:02
@ckairen
Copy link
Member Author

ckairen commented Sep 30, 2024 •
edited
Loading

pipeline run:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=4186428&view=logs&j=a7bbfb1e-9b1d-5480-b954-b42b4949e5ba&t=d2882e8e-3f84-5d13-b2a9-0f13ca3ef387

pr comment generated by this step: #5932 (comment)

@ckairen
Copy link
Member Author

ckairen commented Sep 30, 2024

all of the azure-template changes are for testing purposes, will delete before merging

danieljurek
danieljurek approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Revert the changes to template package before merging.

@ckairen ckairen merged commit 9f2b00b into Azure:main Oct 4, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp left review comments

@LarryOsterman LarryOsterman LarryOsterman left review comments

@weshaggard weshaggard weshaggard left review comments

@maririos maririos maririos left review comments

@danieljurek danieljurek danieljurek approved these changes

@praveenkuttappan praveenkuttappan praveenkuttappan approved these changes

@antkmsft antkmsft Awaiting requested review from antkmsft

@schaabs schaabs Awaiting requested review from schaabs

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan

@RickWinter RickWinter Awaiting requested review from RickWinter

@gearama gearama Awaiting requested review from gearama

@maorleger maorleger Awaiting requested review from maorleger maorleger was automatically assigned from Azure/azure-sdk-write-identity

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck was automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya was automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell was automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki was automatically assigned from Azure/azure-sdk-write-identity

Assignees

@ckairen ckairen

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APIView support in C++ PRs
8 participants
@ckairen @praveenkuttappan @benbp @azure-sdk @danieljurek @LarryOsterman @weshaggard @maririos