Fix etag.hpp comment that breaks Doxygen 1.12.0 #6014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, "*" breaks Doxygen 1.12.0 with the following error:
error: end of comment block while expecting command </em>
I have no idea why. Anything else like '*' or "x" works, but "*" was
clearly intended here. The best I can suggest is: * in quotes.
chewi
requested review from
RickWinter,
ahsonkhan,
antkmsft,
gearama and
LarryOsterman
as code owners
github-actions
bot
added
Azure.Core
Community Contribution
|
Thank you for your contribution @chewi! We will review the pull request and get back to you soon. |
|
Thank you for this change. |
LarryOsterman
approved these changes
Sep 20, 2024
azure-sdk
added a commit
to azure-sdk/vcpkg
that referenced
this pull request
Oct 3, 2024
## 1.14.0 (2024-10-03) ### Features Added - Added a new constructor for `Azure::Core::Context` that takes an `Azure::DateTime` deadline. This enables creating a new context directly with a deadline. - Request logs to now include the `accept-range`, `content-range`, `range`, `WWW-Authenticate`, `x-ms-date`, `x-ms-error-code`, `x-ms-range`, and `x-ms-version` headers. - Added default constructor, `Parse()`, and equality comparison operators to `Azure::Core::Uuid`. - Added an `Azure::Core::ResourceIdentifier` type. ### Breaking Changes - Deprecated the `Azure::Core::Context::ApplicationContext` object. - If customer code is using `Azure::Core::Context::ApplicationContext`, the customer should instead create their own root context object which is used wherever the customer would have previously used `Azure::Core::Context::ApplicationContext`, i.e. `Azure::Core::Context(deadline)` instead of `Azure::Core::Context::ApplicationContext.WithDeadline(deadline)`. ### Bugs Fixed - Throw `std::invalid_argument` if the value of `TimeFractionFormat` enum passed in to `DateTime::ToString()` is invalid. - `Azure::Core::Uuid::ToString()` is now `const`. - Make the HTTP transport behavior consistent between WinHTTP and libcurl by disabling automatically following redirects on Windows. - Added basic input validation to `Azure::Core::ResourceIdentifier` to ensure the prefix match what is expected. ### Other Changes - [[microsoft#5851]](Azure/azure-sdk-for-cpp#5851) Remove unneeded `<regex>` includes. (A community contribution, courtesy of _[rschu1ze](https://github.com/rschu1ze)_) - [[microsoft#6014]](Azure/azure-sdk-for-cpp#6014), [[microsoft#6016]](Azure/azure-sdk-for-cpp#6016) Fixes for Doxygen generation. (A community contribution, courtesy of _[chewi](https://github.com/chewi)_) ### Acknowledgments Thank you to our developer community members who helped to make Azure Core better with their contributions to this release: - Robert Schulze _([GitHub](https://github.com/rschu1ze))_ - James Le Cuirot _([GitHub](https://github.com/chewi))_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately,
"*"breaks Doxygen 1.12.0 with the following error:I have no idea why. Anything else like
'*'or"x"works, but"*"was clearly intended here. The best I can suggest is:* in quotes.Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.