Integrate Rust 2 step message receive code to C++ #6349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryOsterman
requested review from
RickWinter,
ahsonkhan,
antkmsft and
gearama
as code owners
heaths
approved these changes
Jan 15, 2025
sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/README.md
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/Test-Cleanup.ps1
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/examples/connection.rs
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/src/fe2o3/connection.rs
Outdated
Show resolved
Hide resolved
LarryOsterman
force-pushed
the
feature/rust_amqp
branch
from
d9d8276 to
b7fa9fb
Compare
LarryOsterman
force-pushed
the
larryo/integrate_explicit_message
branch
from
17f7d41 to
20fc8c2
Compare
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
LarryOsterman
added a commit
that referenced
this pull request
Jan 28, 2025
* Integrate Rust 2 step message receive code to C++ * If receiving a delivery failed, transmit the error to the message channel if at all possible
LarryOsterman
added a commit
that referenced
this pull request
Jan 30, 2025
* Integrate Rust 2 step message receive code to C++ * If receiving a delivery failed, transmit the error to the message channel if at all possible
LarryOsterman
added a commit
that referenced
this pull request
Feb 4, 2025
* Integrate Rust 2 step message receive code to C++ * If receiving a delivery failed, transmit the error to the message channel if at all possible
LarryOsterman
added a commit
that referenced
this pull request
Mar 1, 2025
* Integrate Rust 2 step message receive code to C++ * If receiving a delivery failed, transmit the error to the message channel if at all possible
LarryOsterman
added a commit
that referenced
this pull request
Mar 3, 2025
* Integrate Rust 2 step message receive code to C++ * If receiving a delivery failed, transmit the error to the message channel if at all possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the recent Rust repository changes to the AMQP layer.
This change implements a two-step receive process for AMQP - you receive deliveries and then accept or reject them.
GitHub Copilot Summary:
This pull request includes several changes to the
azure-core-amqppackage, focusing on improving testing setup, enhancing connection handling, and adding new functionalities. The most important changes include the addition of new test setup and cleanup scripts, updates to the README for testing instructions, and modifications to the connection and receiver handling.Testing Enhancements:
sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/README.md: Updated the README with detailed instructions on setting up and running tests, including cloning, building, and running the TestAmqpBroker.sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/Test-Setup.ps1: Added a new PowerShell script to automate the setup of the TestAmqpBroker, including cloning the repository and building the broker.sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/Test-Cleanup.ps1: Added a new PowerShell script to clean up after tests, including stopping and removing the test broker job.Connection Handling:
sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/src/connection.rs: Added new async tests for opening and closing AMQP connections, including error handling scenarios.sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/src/fe2o3/connection.rs: Enhanced theclose_with_errormethod to handle transport errors gracefully and added logging for better debugging.Receiver Handling:
sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/src/fe2o3/receiver.rs: Added methods to set and get the credit mode for receivers, improving the control over message flow.Additional Changes:
sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/Cargo.toml: Addedtokioas a dev dependency to support async testing.sdk/core/azure-core-amqp/src/impl/rust_amqp/rust_amqp/azure_core_amqp/examples/connection.rs: Added a new example for AMQP connection handling, including opening, closing, and error scenarios.