-
Notifications
You must be signed in to change notification settings - Fork 143
Re-enabled Mac HTTPBIN tests #6638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Re-enabled Mac HTTPBIN tests #6638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Re-enables HTTPBIN tests on macOS by removing the platform‐specific disable directives.
- Removed the
AZ_PLATFORM_MACguard and_azure_DISABLE_HTTP_BIN_TESTSdefinition - All HTTPBIN tests will now run on macOS
antkmsft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of today, this is PR a test/experiment, correct? Because you've just merged a PR introducing it less than an hour ago, I believe, and now you're undoing the main thing from there. Should this PR be a Draft, or am I missing something?
|
Hi @LarryOsterman. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @LarryOsterman. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.