changelog for storage common and blob #974
Conversation
Jinming-Hu
added
Client
Jinming-Hu
requested review from
antkmsft,
katmsft,
RickWinter,
vhvb1989 and
vinjiang
as code owners
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
|
Look through these: |
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
|
Changed path of blobs.hpp and others: |
|
Made |
|
Renamed/removed storage_version.hpp and added version.hpp |
Is that even worth mentioning in changelog? Because it sounds to me pretty much just an implementation detail. How is our customers' code gonna be affected? |
I agree its a subtle change but can be considered breaking (though unlikely, someone could have forward declared it with the same name). We called out the exception struct -> class change in
|
| @@ -1,10 +1,23 @@ | |||
| # Release History | |||
|
|
|||
| ## 1.0.0-beta.5 (Unreleased) | |||
| ## 12.0.0-beta.5 (2020-11-13) | |||
There was a problem hiding this comment.
@weshaggard would our build and release pipeline be able to handle this version jump from 1.0.0-beta.4 to 12.0.0-beta.5?
|
|
||
| ### New Features | ||
|
|
||
| * Support for replaceable HTTP transport layer. |
There was a problem hiding this comment.
Is this the new TransportPolicyOptions member as part of client options?
| ### New Features | ||
|
|
||
| * Support for replaceable HTTP transport layer. | ||
| * Add `version.hpp`. | ||
|
|
||
| ### Breaking Changes |
There was a problem hiding this comment.
I am surprised, but did we really have no bug fixes reported or made during this release? I don't see any myself, but maybe I missed it, so just want to confirm.
There was a problem hiding this comment.
no, i'm not really good at writing bugs.
These are some fun commit messages :p |
| ### New Features | ||
|
|
||
| * Support for replaceable HTTP transport layer. | ||
| * Add `version.hpp`. |
There was a problem hiding this comment.
super nit: If you would like to fix this going forward and for this current changelog, let's use past-tense similar to #978
https://github.com/Azure/azure-sdk-for-c/releases/tag/1.0.0
https://github.com/Azure/azure-sdk-for-cpp/releases/tag/azure-core_1.0.0-beta.3
The writing style will continue to differ (and we don't really enforce this), so not a big deal either way, but we can try to make an effort on consistent styling. Up to you.
For example:
| * Add `version.hpp`. | |
| * Added `version.hpp`. |
There was a problem hiding this comment.
Actually, we did have this conversation within our team. It seems that it is just a personal style. If you take a look at TensorFlow you would find even within one file there are both styles. Search for Add will give you both past tense and simple present tense of the changelog.
There was a problem hiding this comment.
Yes, I understand. Either is fine. Just wanted to mention it, in case we want to try to converge to one style. Leaving it as is, is fine as well :)
No description provided.