Skip to content

Commit

Permalink
[Tables] connection string parser (#15187)
Browse files Browse the repository at this point in the history
* adding conn str parser

* Basic conn str parser

* adding support for custom domains

* invalid tests

* adding self note

* Update sdk/tables/aztable/connection_string.go

Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>

* Update sdk/tables/aztable/connection_string.go

Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>

* improving testing

* finishing connection string portion

* formatting and improved error handling

* docstring addition for private method

* connection string error

* splitn instead of split

* sas comment

* updating proxy-server script

* configure proxy with hash of file, correct file location

* using certs in main

* trying download with no password

* trying without the pfx file altogether

* adding pfx portion back

* manual copy of testproxy to common

* using common

* fixing path

* adding trust ps1 script

* adding step to run proxy

* formatting and go mod x/net

* fixing for latest azcore

* fixing rqeuire

* removing eng stuff

* conn str

* running tests

* run tests = true

* adding build sourcesDir

* relative path

* fixing up path

* build-test

* moving byte array response inside table pager

* env var playing to fix ci lint

* changing package name

Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>
  • Loading branch information
seankane-msft and richardpark-msft authored Aug 24, 2021
1 parent 088d5b0 commit 7e6523f
Show file tree
Hide file tree
Showing 11 changed files with 494 additions and 270 deletions.
6 changes: 5 additions & 1 deletion eng/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@
},
{
"Name": "internal",
"CoverageGoal": 0.90
"CoverageGoal": 0.70
},
{
"Name": "tables",
"CoverageGoal": 0.01
}
]
}
6 changes: 6 additions & 0 deletions eng/pipelines/templates/steps/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ steps:
displayName: "Install Coverage and Junit Dependencies"
workingDirectory: '${{parameters.GoWorkspace}}'
- template: /eng/common/testproxy/test-proxy-docker.yml

- pwsh: |
$testDirs = (./eng/scripts/get_test_dirs.ps1 -serviceDir $(SCOPE))
foreach ($td in $testDirs) {
Expand All @@ -48,10 +50,14 @@ steps:
workingDirectory: '${{parameters.GoWorkspace}}'
env:
GO111MODULE: 'on'
AZURE_RECORD_MODE: 'playback'
PROXY_CERT: $(Build.SourcesDirectory)/eng/common/testproxy/dotnet-devcert.crt
- pwsh: ../eng/scripts/create_coverage.ps1 ${{parameters.ServiceDirectory}}
displayName: 'Generate Coverage XML'
workingDirectory: '${{parameters.GoWorkspace}}sdk'
env:
GO111MODULE: 'off'

- task: PublishTestResults@2
condition: succeededOrFailed()
Expand Down
22 changes: 0 additions & 22 deletions eng/pipelines/templates/steps/configure-proxy.yml

This file was deleted.

66 changes: 0 additions & 66 deletions eng/scripts/proxy-server.ps1

This file was deleted.

181 changes: 0 additions & 181 deletions sdk/tables/aztable/byte_array_response.go

This file was deleted.

Loading

0 comments on commit 7e6523f

Please sign in to comment.