Skip to content

Commit

Permalink
Responding to review feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
marstr committed Feb 24, 2017
1 parent deb11a7 commit 96b5de8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
6 changes: 1 addition & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,10 @@ script:
- bash rungas.sh
- test -z "$(gofmt -s -l $(find ./arm/* -type d -print) | tee /dev/stderr)"
- test -z "$(gofmt -s -l -w management | tee /dev/stderr)"
- test -z "$(gofmt -s -l -w storage | tee /dev/stderr)"
- test -z "$(gofmt -s -l -w Gododir | tee /dev/stderr)"
- test -z "$(go build $(find ./* -type d -print | grep -v '^./vendor$') | tee /dev/stderr)"
- test -z "$(go build $(find ./* -type d -print | grep -v '^./vendor$' | grep -v '^./storage$') | tee /dev/stderr)"
- test -z "$(go vet $(find ./arm/* -type d -print) | tee /dev/stderr)"
- test -z "$(golint ./arm/... | tee /dev/stderr)"
- go test -v ./storage/... -check.v
- test -z "$(golint ./storage/... | tee /dev/stderr)"
- go vet ./storage/...
- go test -v ./management/...
- test -z "$(golint ./management/... | grep -v 'should have comment' | grep -v 'stutters' | tee /dev/stderr)"
- go vet ./management/...
Expand Down
7 changes: 1 addition & 6 deletions Gododir/gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -386,15 +386,14 @@ func initAndAddService(service *service, inputPrefix, plane string) {
}

func tasks(p *do.Project) {
p.Task("default", do.S{"setvars", "generate:all", "storage", "management"}, nil)
p.Task("default", do.S{"setvars", "generate:all", "management"}, nil)
p.Task("setvars", nil, setVars)
p.Use("generate", generateTasks)
p.Use("gofmt", formatTasks)
p.Use("gobuild", buildTasks)
p.Use("golint", lintTasks)
p.Use("govet", vetTasks)
p.Use("delete", deleteTasks)
p.Task("storage", do.S{"setvars"}, storageVersion)
p.Task("management", do.S{"setvars"}, managementVersion)
}

Expand Down Expand Up @@ -506,10 +505,6 @@ func vet(service *service) {
}
}

func storageVersion(c *do.Context) {
version("storage")
}

func managementVersion(c *do.Context) {
version("management")
}
Expand Down

0 comments on commit 96b5de8

Please sign in to comment.