Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need help to investigate the failure in swagger PR for AKS new API version 2021-09-01 #15675

Closed
AbelHu opened this issue Sep 30, 2021 · 3 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Compute Mgmt This issue is related to a management-plane library. Previous Versions Work related to track1 and track1.5 SDKs

Comments

@AbelHu
Copy link
Member

AbelHu commented Sep 30, 2021

Bug Report

  • import path of package in question, e.g. .../services/compute/mgmt/2018-06-01/compute
  • SDK version e.g. master, latest, 18.1.0
    • Specify the exact commit if possible; one way to get this is the REVISION
      column output by dep status "github.com/Azure/azure-sdk-for-go.
  • output of go version
  • What happened?
  • What did you expect or want to happen?
  • How can we reproduce it?
  • Anything we should know about your environment.

We created a PR for AKS new API version 2021-09-01 but it hit an error with azure-sdk-for-go in validation test. We need your help as @chengliangli0918 'azure-sdk-for-go-track2' failure needs input from go SDK owner. This check didn't fail in 2021-08-01 and 2021-07-01 API merging PR.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 30, 2021
@AbelHu
Copy link
Member Author

AbelHu commented Oct 1, 2021

ping! This blocks AKS new API version 2021-09-01. We need your help.

@jhendrixMSFT
Copy link
Member

Per internal conversation this was introduced in Azure/azure-rest-api-specs#15054 which way likely intentional so that the swagger matches what comes over the wire. The CI failure is non-blocking so you can proceed.

@ArcturusZhang will this continue to show up in future PRs?

@RickWinter RickWinter added bug This issue requires a change to an existing behavior in the product in order to be resolved. Compute Mgmt This issue is related to a management-plane library. Previous Versions Work related to track1 and track1.5 SDKs labels Oct 4, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 4, 2021
@RickWinter RickWinter added this to the [2021] November milestone Oct 4, 2021
@ArcturusZhang
Copy link
Member

Per internal conversation this was introduced in Azure/azure-rest-api-specs#15054 which way likely intentional so that the swagger matches what comes over the wire. The CI failure is non-blocking so you can proceed.

@ArcturusZhang will this continue to show up in future PRs?

We have some internal issues with the go version in the agent which runs SDK automation. This is not resolved yet, we hope it could be resolved soon. But for now, we could just ignore that failure, which is not required and will not block you from merging the PR. FYI @AbelHu and it would close this issue now.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Compute Mgmt This issue is related to a management-plane library. Previous Versions Work related to track1 and track1.5 SDKs
Projects
None yet
Development

No branches or pull requests

4 participants