AKS: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec #15054

kaiqzhan · 2021-07-01T20:01:38Z

This pull request fixed the .NET SDK generation by renaming the pod identity provisioning error object to ManagedClusterPodIdentityProvisioningError. The definition of this object is identical to CloudError. This change unblocked the .NET SDK generation.
#15033

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify: Fix .NET SDK generation error
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…or for AAD pod identity provisioning spec

openapi-workflow-bot · 2021-07-01T20:01:41Z

Hi, @kaiqzhan Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-07-01T20:01:42Z

Swagger Validation Report

️⌛BreakingChange pending [Detail]

️⌛LintDiff pending [Detail]

️⌛Avocado pending [Detail]

️⌛ModelValidation pending [Detail]

️⌛SemanticValidation pending [Detail]

️⌛Cross-Version Breaking Changes pending [Detail]

️⌛CredScan pending [Detail]

️⌛[Staging] SDK Track2 Validation pending [Detail]

️⌛[Staging] PrettierCheck pending [Detail]

️⌛[Staging] SpellCheck pending [Detail]

️⌛[Staging] Lint(RPaaS) pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-07-01T20:01:42Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-07-01T20:01:42Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from b5b3ae9. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-containerservice [View full logs] [Release SDK Changes]
- azure-mgmt-containerservice-12.0.0.zip
- azure_mgmt_containerservice-12.0.0-py2.py3-none-any.whl
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from b5b3ae9. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-containerservice [View full logs] [Release SDK Changes]
- azure_mgmt_containerservice-16.0.0-py2.py3-none-any.whl
- azure-mgmt-containerservice-16.0.0.zip
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from b5b3ae9. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-07-01 21:14:48 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-containerservice-generated"
cmderr	[generate.py] 2021-07-01 21:14:48 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-07-01 21:14:48 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/containerservice/azure-resourcemanager-containerservice-generated --java.namespace=com.azure.resourcemanager.containerservice.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/containerservice/resource-manager/readme.md
cmderr	[generate.py] 2021-07-01 21:15:29 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-07-01 21:15:29 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-07-01 21:15:29 INFO [POM][Skip] pom already has module azure-resourcemanager-containerservice-generated
cmderr	[generate.py] 2021-07-01 21:15:29 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-07-01 21:15:29 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-07-01 21:15:29 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-containerservice-generated [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-07-01 21:17:02 DEBUG Got artifact_id: azure-resourcemanager-containerservice-generated
cmderr	[Inst] 2021-07-01 21:17:02 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-07-01 21:17:02 DEBUG Got artifact: azure-resourcemanager-containerservice-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-07-01 21:17:02 DEBUG Match jar package: azure-resourcemanager-containerservice-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-07-01 21:17:02 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15054/azure-sdk-for-java/azure-resourcemanager-containerservice-generated/azure-resourcemanager-containerservice-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-containerservice-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-containerservice-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-containerservice-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b5b3ae9. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️containerservice/mgmt/2021-05-01/containerservice [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 5 items here, please refer to log for details.

info	[Changelog] - New struct `ManagedClusterPodIdentityProvisioningError`
info	[Changelog] - New struct `ManagedClusterPodIdentityProvisioningErrorBody`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 4 additive change(s).
info	[Changelog]

️✔️containerservice/mgmt/2021-03-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2021-02-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2020-12-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2020-11-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2020-09-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2020-07-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2020-06-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2020-04-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2020-03-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2020-02-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2020-01-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2019-11-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2019-10-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2019-08-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2019-06-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2019-04-30/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2018-03-31/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2017-09-30/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2017-08-31/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2017-07-01/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/containerservice/mgmt/2019-10-27-preview/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/containerservice/mgmt/2019-09-30-preview/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/containerservice/mgmt/2019-02-01-preview/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/containerservice/mgmt/2018-09-30-preview/containerservice [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/containerservice/mgmt/2018-08-01-preview/containerservice [View full logs]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b5b3ae9. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/containerservice/resource-manager/readme.md

️✔️@azure/arm-containerservice [View full logs] [Release SDK Changes]

azure-arm-containerservice-13.3.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
cmderr	[npmPack] created ./dist/arm-containerservice.js in 534ms

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from b5b3ae9. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/containerservice/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.ContainerService [View full logs] [Release SDK Changes]

cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/containerservice/Microsoft.Azure.Management.ContainerService/tests/Tests/Tests/ContainerServiceOpsTests.cs(28,76): error CS1061: 'ContainerServiceClient' does not contain a definition for 'ContainerServices' and no accessible extension method 'ContainerServices' accepting a first argument of type 'ContainerServiceClient' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/containerservice/Microsoft.Azure.Management.ContainerService/tests/Microsoft.Azure.Management.ContainerService.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/containerservice/Microsoft.Azure.Management.ContainerService/tests/Tests/Tests/ContainerServiceOpsTests.cs(28,76): error CS1061: 'ContainerServiceClient' does not contain a definition for 'ContainerServices' and no accessible extension method 'ContainerServices' accepting a first argument of type 'ContainerServiceClient' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/containerservice/Microsoft.Azure.Management.ContainerService/tests/Microsoft.Azure.Management.ContainerService.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from b5b3ae9. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️containerservice [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

allenjzhang · 2021-07-01T20:54:17Z

Pipeline gree: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=978142&view=logs&j=2be18a23-047c-5c9f-61d7-60a33437d1f1.

…or for AAD pod identity provisioning spec (Azure#15054) Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com>

AKS: replace CloudError with ManagedClusterPodIdentityProvisioningErr…

a383113

…or for AAD pod identity provisioning spec

openapi-assignment-bot bot assigned PhoenixHe-NV Jul 1, 2021

allenjzhang approved these changes Jul 1, 2021

View reviewed changes

allenjzhang merged commit b5b3ae9 into Azure:master Jul 1, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jul 1, 2021

jhendrixMSFT mentioned this pull request Oct 1, 2021

Need help to investigate the failure in swagger PR for AKS new API version 2021-09-01 Azure/azure-sdk-for-go#15675

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AKS: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec #15054

AKS: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec #15054

kaiqzhan commented Jul 1, 2021

openapi-workflow-bot bot commented Jul 1, 2021

openapi-pipeline-app bot commented Jul 1, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jul 1, 2021

openapi-pipeline-app bot commented Jul 1, 2021 •

edited

Loading

Breaking Changes Tracking

allenjzhang commented Jul 1, 2021

AKS: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec #15054

AKS: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec #15054

Conversation

kaiqzhan commented Jul 1, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jul 1, 2021

openapi-pipeline-app bot commented Jul 1, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Jul 1, 2021

openapi-pipeline-app bot commented Jul 1, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

allenjzhang commented Jul 1, 2021

openapi-pipeline-app bot commented Jul 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jul 1, 2021 •

edited

Loading